Re: [Qemu-devel] [PATCH v2 0/4] set the OEM fields in the RSDT and the FADT from the SLIC

[Laszlo Ersek <lersek@redhat.com>]

On 01/27/16 19:31, Laszlo Ersek wrote:
> On 01/18/16 15:12, Laszlo Ersek wrote:
>> This is version 2 of
>> <http://thread.gmane.org/gmane.comp.emulators.qemu/386728>.
>>
>> Changes in v2 (also annotated per patch):
>> - introduce acpi_get_slic_oem() [MST],
>> - drop machine property that disables the SLIC-based override [MST].
>>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Cc: Aleksei Kovura <alex3kov@zoho.com>
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> Cc: Michael Tokarev <mjt@tls.msk.ru>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Richard W.M. Jones <rjones@redhat.com>
>> Cc: Shannon Zhao <zhaoshenglong@huawei.com>
>> Cc: Steven Newbury <steve@snewbury.org.uk>
>> Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (4):
>>   acpi: take oem_id in build_header(), optionally
>>   acpi: expose oem_id and oem_table_id in build_rsdt()
>>   acpi: add function to extract oem_id and oem_table_id from the user's
>>     SLIC
>>   pc: set the OEM fields in the RSDT and the FADT from the SLIC
>>
>>  include/hw/acpi/acpi.h      |  7 +++++++
>>  include/hw/acpi/aml-build.h |  5 +++--
>>  hw/acpi/aml-build.c         | 14 ++++++++++----
>>  hw/acpi/core.c              | 16 ++++++++++++++++
>>  hw/acpi/nvdimm.c            |  4 ++--
>>  hw/arm/virt-acpi-build.c    | 14 +++++++-------
>>  hw/i386/acpi-build.c        | 31 ++++++++++++++++++-------------
>>  qemu-options.hx             |  4 ++++
>>  8 files changed, 67 insertions(+), 28 deletions(-)
>>
> 
> Ping -- here's the review & testing feedback thus far:
> 
> patch 1: Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>
>          Reviewed-by: Steven Newbury <steve@snewbury.org.uk>
>          Tested-by: Aleksei Kovura <alex3kov@zoho.com>
> 
> patch 2: Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>
>          Reviewed-by: Steven Newbury <steve@snewbury.org.uk>
>          Tested-by: Aleksei Kovura <alex3kov@zoho.com>
> 
> patch 3: Reviewed-by: Steven Newbury <steve@snewbury.org.uk>
>          Tested-by: Aleksei Kovura <alex3kov@zoho.com>
> 
> patch 4: Reviewed-by: Steven Newbury <steve@snewbury.org.uk>
>          Tested-by: Aleksei Kovura <alex3kov@zoho.com>
> 
> (Tested-by inferred from
> <https://bugzilla.redhat.com/show_bug.cgi?id=1248758#c28>.)
> 
> Michael, Igor, can one of you guys please pick this up?

Ping #2.