Re: [PATCH net-next] bonding: 3ad: apply ad_actor settings changes immediately

[Nikolay Aleksandrov <nikolay@cumulusnetworks.com>]

On 02/03/2016 08:05 PM, Jay Vosburgh wrote:
> Nikolay Aleksandrov <razor@blackwall.org> wrote:
> 
>> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>>
>> Currently the bonding allows to set ad_actor_system and prio while the
>> bond device is down, but these are actually applied only if there aren't
>> any slaves yet (applied to bond device when first slave shows up, and to
>> slaves at 3ad bind time). After this patch changes are applied immediately
>> and the new values can be used/seen after the bond's upped so it's not
>> necessary anymore to release all and enslave again to see the changes.
>>
>> CC: Jay Vosburgh <j.vosburgh@gmail.com>
>> CC: Veaceslav Falico <vfalico@gmail.com>
>> CC: Andy Gospodarek <gospo@cumulusnetworks.com>
>> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> 
> 	Looks good to me.
> 
> Signed-off-by: Jay Vosburgh <jay.vosburgh@canonical.com>
> 
> 	-J
> 

Thanks Jay. Do you think it makes sense to allow setting these while the
bond is up ? I don't see any serious problems.