From: Peter Hurley <peter@hurleysoftware.com>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Pranith Kumar <bobby.prani@gmail.com>,
David Howells <dhowells@redhat.com>, Tejun Heo <tj@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
David Woodhouse <David.Woodhouse@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init: print warning message if /dev/console failed to open
Date: Wed, 3 Feb 2016 11:29:33 -0800 [thread overview]
Message-ID: <56B2551D.807@hurleysoftware.com> (raw)
In-Reply-To: <1454525928-17190-1-git-send-email-kuleshovmail@gmail.com>
Hi Alexander,
On 02/03/2016 10:58 AM, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> init/do_mounts.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index dea5de9..ca5da05 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -505,7 +505,9 @@ void __init change_floppy(char *fmt, ...)
> termios.c_lflag |= ICANON;
> sys_ioctl(fd, TCSETSF, (long)&termios);
> sys_close(fd);
> - }
> + } else
> + pr_err("Warning: unable to open /dev/console.\n");
I think you should include the -fd error code as well.
Is this failure new?
Regards,
Peter Hurley
> +
> }
> #endif
>
>
prev parent reply other threads:[~2016-02-03 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 18:58 [PATCH] init: print warning message if /dev/console failed to open Alexander Kuleshov
2016-02-03 19:09 ` Pranith Kumar
2016-02-03 19:29 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B2551D.807@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.