From: Jens Axboe <axboe@kernel.dk>
To: Eric Whitney <enwlinux@gmail.com>, fio@vger.kernel.org
Subject: Re: [PATCH] fio: fix ignore_error regression
Date: Wed, 3 Feb 2016 16:59:32 -0700 [thread overview]
Message-ID: <56B29464.5060501@kernel.dk> (raw)
In-Reply-To: <20160203232302.GA4500@localhost.localdomain>
On 02/03/2016 04:23 PM, Eric Whitney wrote:
> Commit e9d512d8e7d2 introduced a regression affecting handling for
> the ignore_error parameter. The common code for io_u event handling
> pulled from do_io() and do_verify() into io_queue_event() does not
> check for and process errors that are to be ignored in the main I/O
> path as I/Os are completed. Prior to that commit, do_io() called
> break_on_this_error() to handle that case.
>
> The change causes fio to return a non-zero exit status after
> encountering an error it should ignore while performing I/O, even
> though the job does run to completion. This regression causes
> failures for some fstests that use fio, including ext4/302, ext4/303,
> and generic/300.
>
> This patch restores the original error handling behavior.
Thanks Eric, good catch! Applied.
--
Jens Axboe
prev parent reply other threads:[~2016-02-03 23:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 23:23 [PATCH] fio: fix ignore_error regression Eric Whitney
2016-02-03 23:59 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B29464.5060501@kernel.dk \
--to=axboe@kernel.dk \
--cc=enwlinux@gmail.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.