All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/4] common: env_mmc: support loading env from different cards
Date: Thu, 4 Feb 2016 10:13:12 +0100	[thread overview]
Message-ID: <56B31628.7000800@denx.de> (raw)
In-Reply-To: <20160203010129.GA9205@linux-7smt.suse>

Hi Peng,

On 03/02/2016 02:01, Peng Fan wrote:
> Hi Stefano,
> 
> On Tue, Feb 02, 2016 at 08:46:09PM +0100, Stefano Babic wrote:
>> Hi Peng,
>>
>> On 17/12/2015 05:43, Peng Fan wrote:
>>> Some boards support booting from different SD card slots.
>>> For example, mx6dpsabresd board supports booting from SD2,
>>> SD3, EMMC4, using different boot switch. And the index
>>> numbers are SD2(0), SD3(1), EMMC4(2).
>>> But CONFIG_SYS_MMC_ENV_DEV is hardcoded to 1(for SD3), so when
>>> booting from SD2(using 0), uboot complains "MMC: no card present",
>>> since there is no card in SD3 slot.
>>>
>>> This patch introduces a weak function which still returns
>>> CONFIG_SYS_MMC_ENV_DEV to avoid break other boards. Then
>>> different boards can implement mmc_get_env_devno to read
>>> env from the correct sd/emmc.
>>>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> Cc: Stefano Babic <sbabic@denx.de>
>>> Cc: Simon Glass <sjg@chromium.org>
>>> Cc: Tim Harvey <tharvey@gateworks.com>
>>> Cc: Hans de Goede <hdegoede@redhat.com>
>>> ---
>>>
>>
>> Tom sets this patch as deferred - then applying the rest of the series
>> makes no sense. Patchset should be rechecked later after next release.
> 
> Could you please check these three patches. I may missed to use V3, but still used V2.
> The three patches are new for the env no.
> 
> https://patchwork.ozlabs.org/patch/574586/
> https://patchwork.ozlabs.org/patch/574587/
> https://patchwork.ozlabs.org/patch/574588/
> 

I have not tested, but they looks fine - I am picking them up before my PR.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2016-02-04  9:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17  4:43 [U-Boot] [PATCH V2 1/4] imx: mx7dsabresd: move mmc_get_env_devno to soc code Peng Fan
2015-12-17  4:43 ` [U-Boot] [PATCH V2 2/4] common: env_mmc: support loading env from different cards Peng Fan
2016-02-02 19:46   ` Stefano Babic
2016-02-03  1:01     ` Peng Fan
2016-02-04  9:13       ` Stefano Babic [this message]
2015-12-17  4:43 ` [U-Boot] [PATCH V2 3/4] imx: mx6: implement mmc_get_env_devno Peng Fan
2015-12-17  4:43 ` [U-Boot] [PATCH V2 4/4] imx: mx6: implement board_mmc_get_env_devno Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B31628.7000800@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.