From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>, Linux I2C <linux-i2c@vger.kernel.org>
Cc: "David E. Box" <david.e.box@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: designware-platform: Drop duplicate module information
Date: Thu, 4 Feb 2016 13:36:58 +0200 [thread overview]
Message-ID: <56B337DA.7080603@linux.intel.com> (raw)
In-Reply-To: <20160202143138.60adac87@endymion>
On 02/02/2016 03:31 PM, Jean Delvare wrote:
> The i2c-designware-platform module has duplicate module information
> when CONFIG_I2C_DESIGNWARE_BAYTRAIL is set. It gets the information
> from both i2c-designware-platdrv and i2c-designware-baytrail. The
> latter is optional extra code which ends up in the same module so it
> should not export module information.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: David E. Box <david.e.box@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/i2c/busses/i2c-designware-baytrail.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> --- linux-4.5-rc2.orig/drivers/i2c/busses/i2c-designware-baytrail.c 2016-02-02 09:02:08.098923894 +0100
> +++ linux-4.5-rc2/drivers/i2c/busses/i2c-designware-baytrail.c 2016-02-02 13:37:34.418855732 +0100
> @@ -11,7 +11,6 @@
> * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> * more details.
> */
> -#include <linux/module.h>
> #include <linux/delay.h>
> #include <linux/device.h>
> #include <linux/acpi.h>
> @@ -151,7 +150,3 @@ int i2c_dw_eval_lock_support(struct dw_i
>
> return 0;
> }
> -
> -MODULE_AUTHOR("David E. Box <david.e.box@linux.intel.com>");
> -MODULE_DESCRIPTION("Baytrail I2C Semaphore driver");
> -MODULE_LICENSE("GPL v2");
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2016-02-04 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 13:31 [PATCH] i2c: designware-platform: Drop duplicate module information Jean Delvare
2016-02-04 11:36 ` Jarkko Nikula [this message]
2016-02-12 18:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B337DA.7080603@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.