From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRId2-0001BT-W6 for qemu-devel@nongnu.org; Thu, 04 Feb 2016 07:03:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRIcz-0003xQ-Mu for qemu-devel@nongnu.org; Thu, 04 Feb 2016 07:03:16 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:39752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRIcz-0003vG-4q for qemu-devel@nongnu.org; Thu, 04 Feb 2016 07:03:13 -0500 References: <1452829066-9764-1-git-send-email-zhang.zhanghailiang@huawei.com> <1452829066-9764-3-git-send-email-zhang.zhanghailiang@huawei.com> <20160204104700.GG20527@grmbl.mre> <20160204105016.GB2427@work-vm> <20160204105730.GH20527@grmbl.mre> <20160204111014.GC2427@work-vm> From: Hailiang Zhang Message-ID: <56B33DE9.1010703@huawei.com> Date: Thu, 4 Feb 2016 20:02:49 +0800 MIME-Version: 1.0 In-Reply-To: <20160204111014.GC2427@work-vm> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of MigrationState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , Amit Shah Cc: quintela@redhat.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org On 2016/2/4 19:10, Dr. David Alan Gilbert wrote: > * Amit Shah (amit.shah@redhat.com) wrote: >> On (Thu) 04 Feb 2016 [10:50:16], Dr. David Alan Gilbert wrote: >>> * Amit Shah (amit.shah@redhat.com) wrote: >>>> On (Fri) 15 Jan 2016 [11:37:42], zhanghailiang wrote: >>>>> Rename the 'file' member of MigrationState to 'to_dst_file'. >>>> >>>> Why? >>>> >>>> (Use this space to explain why you're doing it, rather than repeating >>>> the first line of the commit. It helps when reviewing the git logs >>>> later.) >>> >>> I think the simple answer is consistency; now we've got a bidirectional >>> connection we've already got to_src_file, from_src_file and from_dst_file, >>> so 'file' is an oddity that I was too lazy to rename previously. >> >> Sure, I just mean we need better commit description. Just provide >> one, and I'll use that when doing the pull req. > > I suggest: > > Rename the 'file' memory of MigrationState to 'to_dst_file' to > be consistent with to_src_file, from_src_file and from_dst_file. > A very Good suggestion, thanks. > Dave > >> >> Thanks, >> >> Amit > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > . >