From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRInb-0005t9-H5 for qemu-devel@nongnu.org; Thu, 04 Feb 2016 07:14:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRInW-00068e-Da for qemu-devel@nongnu.org; Thu, 04 Feb 2016 07:14:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRInW-00068a-8g for qemu-devel@nongnu.org; Thu, 04 Feb 2016 07:14:06 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 04A9B32D3C0 for ; Thu, 4 Feb 2016 12:14:06 +0000 (UTC) References: <1454355464-14999-1-git-send-email-drjones@redhat.com> From: Paolo Bonzini Message-ID: <56B3408A.7010401@redhat.com> Date: Thu, 4 Feb 2016 13:14:02 +0100 MIME-Version: 1.0 In-Reply-To: <1454355464-14999-1-git-send-email-drjones@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] kvm-all: trace: strerror fixup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones , qemu-devel@nongnu.org On 01/02/2016 20:37, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > kvm-all.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kvm-all.c b/kvm-all.c > index 9148889921197..330f509a0da84 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -2362,7 +2362,7 @@ int kvm_set_one_reg(CPUState *cs, uint64_t id, void *source) > reg.addr = (uintptr_t) source; > r = kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, ®); > if (r) { > - trace_kvm_failed_reg_set(id, strerror(r)); > + trace_kvm_failed_reg_set(id, strerror(-r)); > } > return r; > } > @@ -2376,7 +2376,7 @@ int kvm_get_one_reg(CPUState *cs, uint64_t id, void *target) > reg.addr = (uintptr_t) target; > r = kvm_vcpu_ioctl(cs, KVM_GET_ONE_REG, ®); > if (r) { > - trace_kvm_failed_reg_get(id, strerror(r)); > + trace_kvm_failed_reg_get(id, strerror(-r)); > } > return r; > } > Applied, thanks! Paolo