Re: [PATCH] IB/IPoIB: Do not set skb truesize since using one linearskb

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]

On 02/03/2016 03:55 PM, clsoto-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org wrote:
> From: Carol L Soto <clsoto-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> 
> We are seeing this warning: at net/core/skbuff.c:4174
> and before commit a44878d10063 ("IB/ipoib: Use one linear skb in RX flow")
> skb truesize was not being set when ipoib was using just one skb. 
> Removing this line avoids the warning when running tcp tests like iperf. 
> 
> Fixes: a44878d10063 ("IB/ipoib: Use one linear skb in RX flow")
> Signed-off-by: Carol L Soto <clsoto-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> 
> ---
>  drivers/infiniband/ulp/ipoib/ipoib_ib.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
> index 5ea0c14..fa9c42f 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
> @@ -245,8 +245,6 @@ static void ipoib_ib_handle_rx_wc(struct net_device *dev, struct ib_wc *wc)
>  	skb_reset_mac_header(skb);
>  	skb_pull(skb, IPOIB_ENCAP_LEN);
>  
> -	skb->truesize = SKB_TRUESIZE(skb->len);
> -
>  	++dev->stats.rx_packets;
>  	dev->stats.rx_bytes += skb->len;
>  
> 

Thanks, applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]