From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Thu, 04 Feb 2016 12:47:41 +0000 Subject: Re: [patch] extcon: use correct size Message-Id: <56B3486D.1050201@bfs.de> List-Id: References: <20160204113609.GA11239@mwanda> In-Reply-To: <20160204113609.GA11239@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: MyungJoo Ham , Jaewon Kim , Chanwoo Choi , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Am 04.02.2016 12:36, schrieb Dan Carpenter: > The info->status[] array has 3 elements. We are using size > MAX77843_MUIC_IRQ_NUM (16) instead of MAX77843_MUIC_STATUS_NUM (3) as > intended. > > Fixes: 135d9f7d135a ('extcon: max77843: Clear IRQ bits state before request IRQ') > Signed-off-by: Dan Carpenter > --- > This is from static analysis and *NOT TESTED*. Please review carefully. > > diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c > index 7bbc300..b188bd6 100644 > --- a/drivers/extcon/extcon-max77843.c > +++ b/drivers/extcon/extcon-max77843.c > @@ -806,7 +806,7 @@ static int max77843_muic_probe(struct platform_device *pdev) > /* Clear IRQ bits before request IRQs */ > ret = regmap_bulk_read(max77843->regmap_muic, > MAX77843_MUIC_REG_INT1, info->status, > - MAX77843_MUIC_IRQ_NUM); > + MAX77843_MUIC_STATUS_NUM); > if (ret) { > dev_err(&pdev->dev, "Failed to Clear IRQ bits\n"); > goto err_muic_irq; > -- just for my curiosity: what is wrong with ARRAY_SIZE() ? So far i understand is the functions intention to fill the array completely. re, wh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756875AbcBDMyA (ORCPT ); Thu, 4 Feb 2016 07:54:00 -0500 Received: from mx01-fr.bfs.de ([193.174.231.67]:35830 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754237AbcBDMxq (ORCPT ); Thu, 4 Feb 2016 07:53:46 -0500 X-Greylist: delayed 352 seconds by postgrey-1.27 at vger.kernel.org; Thu, 04 Feb 2016 07:53:46 EST Message-ID: <56B3486D.1050201@bfs.de> Date: Thu, 04 Feb 2016 13:47:41 +0100 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Dan Carpenter CC: MyungJoo Ham , Jaewon Kim , Chanwoo Choi , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] extcon: use correct size References: <20160204113609.GA11239@mwanda> In-Reply-To: <20160204113609.GA11239@mwanda> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 04.02.2016 12:36, schrieb Dan Carpenter: > The info->status[] array has 3 elements. We are using size > MAX77843_MUIC_IRQ_NUM (16) instead of MAX77843_MUIC_STATUS_NUM (3) as > intended. > > Fixes: 135d9f7d135a ('extcon: max77843: Clear IRQ bits state before request IRQ') > Signed-off-by: Dan Carpenter > --- > This is from static analysis and *NOT TESTED*. Please review carefully. > > diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c > index 7bbc300..b188bd6 100644 > --- a/drivers/extcon/extcon-max77843.c > +++ b/drivers/extcon/extcon-max77843.c > @@ -806,7 +806,7 @@ static int max77843_muic_probe(struct platform_device *pdev) > /* Clear IRQ bits before request IRQs */ > ret = regmap_bulk_read(max77843->regmap_muic, > MAX77843_MUIC_REG_INT1, info->status, > - MAX77843_MUIC_IRQ_NUM); > + MAX77843_MUIC_STATUS_NUM); > if (ret) { > dev_err(&pdev->dev, "Failed to Clear IRQ bits\n"); > goto err_muic_irq; > -- just for my curiosity: what is wrong with ARRAY_SIZE() ? So far i understand is the functions intention to fill the array completely. re, wh