From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH] KVM: Create debugfs statistics for each VM
Date: Thu, 4 Feb 2016 14:10:01 +0100
Message-ID: <56B34DA9.5040004@de.ibm.com>
References: <1453996159-19576-1-git-send-email-frankja@linux.vnet.ibm.com>
 <1453996159-19576-2-git-send-email-frankja@linux.vnet.ibm.com>
 <56B0B9AF.3010305@de.ibm.com> <56B34CA7.4040107@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, dan.carpenter@oracle.com
To: Paolo Bonzini <pbonzini@redhat.com>,
	Janosch Frank <frankja@linux.vnet.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:43767 "EHLO
	e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965564AbcBDNKG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 4 Feb 2016 08:10:06 -0500
Received: from localhost
	by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <borntraeger@de.ibm.com>;
	Thu, 4 Feb 2016 13:10:04 -0000
Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id B561617D805F
	for <kvm@vger.kernel.org>; Thu,  4 Feb 2016 13:10:14 +0000 (GMT)
Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217])
	by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u14DA25O10748402
	for <kvm@vger.kernel.org>; Thu, 4 Feb 2016 13:10:02 GMT
Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u14DA1gq004844
	for <kvm@vger.kernel.org>; Thu, 4 Feb 2016 08:10:02 -0500
In-Reply-To: <56B34CA7.4040107@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 02/04/2016 02:05 PM, Paolo Bonzini wrote:
> 
> 
> On 02/02/2016 15:14, Christian Borntraeger wrote:
>> FWIW, the newly created subfolders,
>>
>> require QEMU commit 6590045e5dd2fb0b1d7cdc047ae0c52fd4bb5276
>>     scripts/kvm/kvm_stat: Replaced os.listdir with os.walk
>>
>> Otherwise you might get errors like 
>>
>> Traceback (most recent call last):
>>   File "scripts/kvm/kvm_stat", line 640, in <module>
>>     curses.wrapper(tui, stats)
>>   File "/usr/lib64/python2.7/curses/wrapper.py", line 43, in wrapper
>>     return func(stdscr, *args, **kwds)
>>   File "scripts/kvm/kvm_stat", line 547, in tui
>>     refresh(sleeptime)
>>   File "scripts/kvm/kvm_stat", line 523, in refresh
>>     s = stats.get()
>>   File "scripts/kvm/kvm_stat", line 483, in get
>>     new = d.read()
>>   File "scripts/kvm/kvm_stat", line 37, in read
>>     return dict([(key, val(key)) for key in self._fields])
>>   File "scripts/kvm/kvm_stat", line 36, in val
>>     return int(file(self.base + '/' + key).read())
>> IOError: [Errno 21] Is a directory: '/sys/kernel/debug/kvm/13123-31'
>>
>> when using the "-d" option.
>>
>>
>> Paolo, I still think that this a valuable addon for debugging. Any guidance?
> 
> Yeah, I agree...  Do we want to add a module parameter for this, and/or
> a kernel configuration that for now defaults to N?
> 


> An alternative is to move kvm_stat from QEMU to tools/.

Hmm, that is probably the best solution, given that it has no dependency
on QEMU but heavily depends on the kernel module.