From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRLYw-0001p2-Cs for qemu-devel@nongnu.org; Thu, 04 Feb 2016 10:11:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRLYq-0005JW-GF for qemu-devel@nongnu.org; Thu, 04 Feb 2016 10:11:14 -0500 Received: from mx2.suse.de ([195.135.220.15]:60874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRLYq-0005JP-9X for qemu-devel@nongnu.org; Thu, 04 Feb 2016 10:11:08 -0500 References: <56B2754B.7030809@redhat.com> <56B28B1C.7060202@redhat.com> <56B28E8B.1030107@redhat.com> <56B326B4.1020407@redhat.com> <56B3550C.1010003@redhat.com> <56B35816.80900@suse.de> <56B36852.8000101@redhat.com> From: Hannes Reinecke Message-ID: <56B36A0B.8070605@suse.de> Date: Thu, 4 Feb 2016 16:11:07 +0100 MIME-Version: 1.0 In-Reply-To: <56B36852.8000101@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] sda abort with virtio-scsi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Jim Minter , qemu-devel On 02/04/2016 04:03 PM, Paolo Bonzini wrote: >> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c >> index 595af1a..f712db5 100644 >> --- a/drivers/scsi/virtio_scsi.c >> +++ b/drivers/scsi/virtio_scsi.c >> @@ -543,6 +543,33 @@ static int virtscsi_abort(struct scsi_cmnd *sc) >> return virtscsi_tmf(vscsi, cmd); >> } >> =20 >> +static enum blk_eh_timer_return virtscsi_timed_out(struct scsi_cmnd *= sc) >> +{ >> + struct virtio_scsi *vscsi =3D shost_priv(sc->device->host); >> + struct virtio_scsi_cmd *cmd; >> + >> + scmd_printk(KERN_INFO, sc, "timeout\n"); >> + cmd =3D mempool_alloc(virtscsi_cmd_pool, GFP_NOIO); >> + if (!cmd) >> + return FAILED; >=20 > Should this be BLK_EH_NOT_HANDLED? Apart from this, the patch looks > good. And of course this doesn't affect Jim, who can test this patch > anyway. >=20 Why, but of course. I'll be sending the official patch to linux-scsi. Cheers, Hannes --=20 Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg GF: F. Imend=C3=B6rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N=C3=BCrnberg)