From: sagig@dev.mellanox.co.il (Sagi Grimberg)
Subject: [PATCH 0/4] NVMe: Surprise removal fixes
Date: Thu, 4 Feb 2016 17:55:05 +0200 [thread overview]
Message-ID: <56B37459.3080602@dev.mellanox.co.il> (raw)
In-Reply-To: <1454515543-21683-1-git-send-email-keith.busch@intel.com>
Hi Keith,
> Earlier feedback suggested this functionality be in the block layer. I
> don't have the devices to test what happens with other drivers, and
> the desired sequence seems unique to NVMe.
Umm, it actually isn't. I think this is what all the block drivers
want.
> Maybe that's an indication
> that the driver's flow could benefit from some redesign, or maybe it's
> an artifact from having the controller and storage being the same device.
>
> In any case, I would like to isolate this fix to the NVMe driver in
> the interest of time, and flush out the block layer before the next
> merge window.
I'm fine with that. But we definitely want to avoid the queue_rq
conditional in the long run...
prev parent reply other threads:[~2016-02-04 15:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 16:05 [PATCH 0/4] NVMe: Surprise removal fixes Keith Busch
2016-02-03 16:05 ` [PATCH 1/4] NVMe: Fix io incapable return values Keith Busch
2016-02-04 15:55 ` Sagi Grimberg
2016-02-08 18:10 ` Christoph Hellwig
2016-02-03 16:05 ` [PATCH 2/4] NVMe: Sync stopped queues with block layer Keith Busch
2016-02-04 15:57 ` Sagi Grimberg
2016-02-04 16:00 ` Keith Busch
2016-02-08 18:11 ` Christoph Hellwig
2016-02-03 16:05 ` [PATCH 3/4] NVMe: Surprise removal fixes Keith Busch
2016-02-08 18:16 ` Christoph Hellwig
2016-02-08 18:38 ` Keith Busch
2016-02-08 23:48 ` Keith Busch
2016-02-03 16:05 ` [PATCH 4/4] blk-mq: End unstarted requests on dying queue Keith Busch
2016-02-04 15:59 ` Sagi Grimberg
2016-02-08 18:13 ` Christoph Hellwig
2016-02-04 3:25 ` [PATCH 0/4] NVMe: Surprise removal fixes Wenbo Wang
2016-02-04 15:52 ` Keith Busch
2016-02-04 15:55 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B37459.3080602@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.