From: Eric Blake <eblake@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, dgilbert@redhat.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 5/6] qmp-commands.hx: Fix the missing options for migration parameters commands
Date: Thu, 4 Feb 2016 09:10:44 -0700 [thread overview]
Message-ID: <56B37804.7030608@redhat.com> (raw)
In-Reply-To: <1454588426-12372-6-git-send-email-zhang.zhanghailiang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
On 02/04/2016 05:20 AM, zhanghailiang wrote:
> We didn't document x-cpu-throttle-initial/x-cpu-throttle-increment for
> commands migrate-set-parameters and query-migrate-parameters.
>
> Here we add the descriptions for these two options and fix the wrong example
> for query-migrate-parameters qmp commands.
> Besides, this will also fix the bug that we cann't set x-cpu-throttle-initial
s/cann't/can't/
> and x-cpu-throttle-increment through migrate-set-parameters qmp command.
>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
> ---
> qmp-commands.hx | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-04 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 12:20 [Qemu-devel] [PATCH v2 0/6] Some improvments and small fixes for migration zhanghailiang
2016-02-04 12:20 ` [Qemu-devel] [PATCH v2 1/6] ram: Split host_from_stream_offset() into two helper functions zhanghailiang
2016-02-04 12:20 ` [Qemu-devel] [PATCH v2 2/6] migration: Rename the'file' member of MigrationState zhanghailiang
2016-02-04 12:20 ` [Qemu-devel] [PATCH v2 3/6] savevm: Split load vm state function qemu_loadvm_state zhanghailiang
2016-02-04 12:20 ` [Qemu-devel] [PATCH v2 4/6] migration/ram: Fix some helper functions' parameter to use PageSearchStatus zhanghailiang
2016-02-04 12:20 ` [Qemu-devel] [PATCH v2 5/6] qmp-commands.hx: Fix the missing options for migration parameters commands zhanghailiang
2016-02-04 16:10 ` Eric Blake [this message]
2016-02-04 12:20 ` [Qemu-devel] [PATCH v2 6/6] qmp-commands.hx: Document the missing options for migration capability commands zhanghailiang
2016-02-04 12:36 ` [Qemu-devel] [PATCH v2 0/6] Some improvments and small fixes for migration Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B37804.7030608@redhat.com \
--to=eblake@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.