All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: "Andreas Irestål" <andreas.irestal@axis.com>
Cc: liam.r.girdwood@linux.intel.com,
	"Andreas Irestål" <andire@axis.com>,
	alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH] ASoC: adau17x1: Cache writes when core clock is disabled
Date: Thu, 4 Feb 2016 18:24:08 +0100	[thread overview]
Message-ID: <56B38938.40000@metafoo.de> (raw)
In-Reply-To: <56B388DC.40601@metafoo.de>

On 02/04/2016 06:22 PM, Lars-Peter Clausen wrote:
[...]
>> +	/* Enable cache only mode as we could miss writes before bias level
>> +	 * reaches standby and the core clock is enabled */
>> +	regcache_cache_only(regmap, true);
>> +
> 
> There are a few register writes before this where the hardware configuration
> is setup. When I look at my test setup those writes seem to go through, even
> though they shouldn't according to what you say (and to what is written in
> the datasheet).
> 
> On the other hand I've never seen the issue you are having either and I've
> tested both master and slave configuration of the device. Maybe something
> changed in the silicon in newer revisions of the device. Can you take a look
> whether the hardware configuration is correctly applied for you?

Ah, no, ignore that. Those writes happen later on.

  reply	other threads:[~2016-02-04 17:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04 14:05 [PATCH] ASoC: adau17x1: Cache writes when core clock is disabled Andreas Irestål
2016-02-04 17:22 ` Lars-Peter Clausen
2016-02-04 17:24   ` Lars-Peter Clausen [this message]
2016-02-04 19:01     ` Andreas Irestål
2016-02-04 19:34       ` Mark Brown
2016-02-05 13:35 ` Applied "ASoC: adau17x1: Cache writes when core clock is disabled" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B38938.40000@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=andire@axis.com \
    --cc=andreas.irestal@axis.com \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.