From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRSDL-00026z-7Y for qemu-devel@nongnu.org; Thu, 04 Feb 2016 17:17:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRSDI-0002dy-HF for qemu-devel@nongnu.org; Thu, 04 Feb 2016 17:17:23 -0500 Received: from mail-qg0-x244.google.com ([2607:f8b0:400d:c04::244]:35638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRSDI-0002dt-Cr for qemu-devel@nongnu.org; Thu, 04 Feb 2016 17:17:20 -0500 Received: by mail-qg0-x244.google.com with SMTP id b35so3328852qge.2 for ; Thu, 04 Feb 2016 14:17:20 -0800 (PST) Sender: Richard Henderson References: <1454597781-18115-1-git-send-email-alex.bennee@linaro.org> <1454597781-18115-5-git-send-email-alex.bennee@linaro.org> From: Richard Henderson Message-ID: <56B3CDE9.5050905@twiddle.net> Date: Fri, 5 Feb 2016 09:17:13 +1100 MIME-Version: 1.0 In-Reply-To: <1454597781-18115-5-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v5 4/9] qemu-log: Improve the "exec" TB execution logging List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Peter Crosthwaite , dgilbert@redhat.com, crosthwaitepeter@gmail.com, pbonzini@redhat.com, aurelien@aurel32.net On 02/05/2016 01:56 AM, Alex Bennée wrote: > From: Peter Maydell > > Improve the TB execution logging so that it is easier to identify > what is happening from trace logs: > * move the "Trace" logging of executed TBs into cpu_tb_exec() > so that it is emitted if and only if we actually execute a TB, > and for consistency for the CPU state logging > * log when we link two TBs together via tb_add_jump() > * log when cpu_tb_exec() returns early from a chain of TBs > > The new style logging looks like this: > > Trace 0x7fb7cc822ca0 [ffffffc0000dce00] > Linking TBs 0x7fb7cc822ca0 [ffffffc0000dce00] index 0 -> 0x7fb7cc823110 [ffffffc0000dce10] > Trace 0x7fb7cc823110 [ffffffc0000dce10] > Trace 0x7fb7cc823420 [ffffffc000302688] > Trace 0x7fb7cc8234a0 [ffffffc000302698] > Trace 0x7fb7cc823520 [ffffffc0003026a4] > Trace 0x7fb7cc823560 [ffffffc0000dce44] > Linking TBs 0x7fb7cc823560 [ffffffc0000dce44] index 1 -> 0x7fb7cc8235d0 [ffffffc0000dce70] > Trace 0x7fb7cc8235d0 [ffffffc0000dce70] > Abandoned execution of TB chain before 0x7fb7cc8235d0 [ffffffc0000dce70] > Trace 0x7fb7cc8235d0 [ffffffc0000dce70] > Trace 0x7fb7cc822fd0 [ffffffc0000dd52c] > > Signed-off-by: Peter Maydell > Signed-off-by: Alex Bennée > [AJB: reword patch title] > Reviewed-by: Aurelien Jarno > --- > cpu-exec.c | 20 +++++++++++--------- > include/exec/exec-all.h | 3 +++ > 2 files changed, 14 insertions(+), 9 deletions(-) Looks good, though I quibble over the term "Abandoned". To me that implies that nothing got executed, which isn't true. I'd prefer "Stopped" or "Exited". Otherwise, Reviewed-by: Richard Henderson r~