From: Bart Van Assche <bart.vanassche@sandisk.com>
To: "Nicholas A. Bellinger" <nab@daterainc.com>,
target-devel <target-devel@vger.kernel.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Mike Christie <mchristi@redhat.com>,
Sagi Grimberg <sagig@mellanox.com>,
Andy Grover <agrover@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Juergen Gross <jgross@suse.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Chris Boot <bootc@bootc.net>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Vu Pham <vu@mellanox.com>
Subject: Re: [PATCH-v3 14/14] ib_srpt: Convert to percpu_ida tag allocation
Date: Thu, 4 Feb 2016 14:23:57 -0800 [thread overview]
Message-ID: <56B3CF7D.1030903@sandisk.com> (raw)
In-Reply-To: <1454137558-30396-15-git-send-email-nab@daterainc.com>
On 01/29/2016 11:05 PM, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
>
> Cc: Vu Pham <vu@mellanox.com>
> Cc: Sagi Grimberg <sagig@mellanox.com>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Hello Nic,
A patch description should not only explain what has been changed but
also why that change is considered useful. That last part is missing
from the description of this patch. Is the purpose of this patch perhaps
to improve performance ? If so then you should provide measurement data
that shows that this patch really improves performance. Personally I
doubt this patch improves performance because in the ib_srpt driver all
ioctx allocations happen on the same CPU core, namely the CPU core the
completion interrupt has been assigned to.
Bart.
prev parent reply other threads:[~2016-02-04 22:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 7:05 [PATCH-v3 00/14] target_alloc_session w/ percpu_ida+ACK_KREF conversion Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 01/14] target: Add target_alloc_session() helper function Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 02/14] target: Convert demo-mode only drivers to target_alloc_session Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 03/14] vhost/scsi: Convert to target_alloc_session usage Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 04/14] tcm_qla2xxx: " Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 05/14] tcm_fc: " Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 06/14] ib_srpt: " Nicholas A. Bellinger
2016-02-04 22:14 ` Bart Van Assche
2016-01-30 7:05 ` [PATCH-v3 07/14] sbp-target: Conversion to percpu_ida tag pre-allocation Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 08/14] sbp-target: Convert to TARGET_SCF_ACK_KREF I/O krefs Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 09/14] usb-gadget/tcm: Conversion to percpu_ida tag pre-allocation Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 10/14] usb-gadget/tcm: Convert to TARGET_SCF_ACK_KREF I/O krefs Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 11/14] xen-scsiback: Convert to percpu_ida tag allocation Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 12/14] xen-scsiback: Convert to TARGET_SCF_ACK_KREF I/O krefs Nicholas A. Bellinger
2016-02-02 16:31 ` Juergen Gross
2016-02-03 5:03 ` Nicholas A. Bellinger
2016-02-04 8:22 ` Juergen Gross
2016-01-30 7:05 ` [PATCH-v3 13/14] tcm_fc: Convert to TARGET_SCF_ACK_KREF I/O + TMR krefs Nicholas A. Bellinger
2016-01-30 7:05 ` [PATCH-v3 14/14] ib_srpt: Convert to percpu_ida tag allocation Nicholas A. Bellinger
2016-02-04 22:23 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B3CF7D.1030903@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=agrover@redhat.com \
--cc=andrzej.p@samsung.com \
--cc=bigeasy@linutronix.de \
--cc=bootc@bootc.net \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jgross@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=nab@daterainc.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
--cc=vu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.