From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRT3I-0001I0-8y for qemu-devel@nongnu.org; Thu, 04 Feb 2016 18:11:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRT3D-0005qt-Ge for qemu-devel@nongnu.org; Thu, 04 Feb 2016 18:11:04 -0500 Received: from mail-qg0-x241.google.com ([2607:f8b0:400d:c04::241]:35571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRT3D-0005qn-Bs for qemu-devel@nongnu.org; Thu, 04 Feb 2016 18:10:59 -0500 Received: by mail-qg0-x241.google.com with SMTP id b35so3390403qge.2 for ; Thu, 04 Feb 2016 15:10:59 -0800 (PST) Sender: Richard Henderson References: <1454597781-18115-1-git-send-email-alex.bennee@linaro.org> <1454597781-18115-10-git-send-email-alex.bennee@linaro.org> From: Richard Henderson Message-ID: <56B3DA7D.5040601@twiddle.net> Date: Fri, 5 Feb 2016 10:10:53 +1100 MIME-Version: 1.0 In-Reply-To: <1454597781-18115-10-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v5 9/9] cputlb: modernise the debug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Peter Crosthwaite , dgilbert@redhat.com, crosthwaitepeter@gmail.com, pbonzini@redhat.com, aurelien@aurel32.net On 02/05/2016 01:56 AM, Alex Bennée wrote: > To avoid cluttering the code with #ifdef legs we wrap up the print > statements into a tlb_debug() macro. As access to the virtual TLB can > get quite heavy defining DEBUG_TLB_LOG will ensure all the logs go to > the qemu_log target of CPU_LOG_MMU instead of stderr. This remains > compile time optional as these debug statements haven't been considered > for usefulness for user visible logging. > > I've also removed DEBUG_TLB_CHECK which wasn't used. > > Signed-off-by: Alex Bennée > > --- > v2 > - ensure compiler checks format strings even if debug is optimised out > v5 > - reword commit to justify not just using qemu_log at this time > --- > cputlb.c | 54 +++++++++++++++++++++++++++++++++++------------------- > 1 file changed, 35 insertions(+), 19 deletions(-) Reviewed-by: Richard Henderson r~