From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/3] x86/mm: drop guest_{map,
	get_eff}_l1e() hooks
Date: Fri, 5 Feb 2016 14:41:57 +0000
Message-ID: <56B4B4B5.9020905@citrix.com>
References: <56B4628602000078000CED9E@prv-mh.provo.novell.com>
	<56B464EA02000078000CEDB7@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=8364524b4=Andrew.Cooper3@citrix.com>)
	id 1aRhaD-0005FQ-3Q
	for xen-devel@lists.xenproject.org; Fri, 05 Feb 2016 14:42:01 +0000
In-Reply-To: <56B464EA02000078000CEDB7@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/02/16 08:01, Jan Beulich wrote:
> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -844,6 +844,15 @@ void paging_final_teardown(struct domain
>   * creation. */
>  int paging_enable(struct domain *d, u32 mode)
>  {
> +    switch ( mode & (PG_external | PG_translate) )
> +    {
> +    case 0:
> +    case PG_external | PG_translate:
> +        break;
> +    default:
> +        return -EINVAL;
> +    }

if ( (mode & PG_external) != (mode & PG_translate) )
    return -EINVAL;

seems rather more concise.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Definitely a good improvement.