From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754117AbcBEO4e (ORCPT ); Fri, 5 Feb 2016 09:56:34 -0500 Received: from smtpoutz299.laposte.net ([178.22.154.199]:40267 "EHLO smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750844AbcBEO4d (ORCPT ); Fri, 5 Feb 2016 09:56:33 -0500 Message-ID: <56B4B81D.3000108@laposte.net> Date: Fri, 05 Feb 2016 15:56:29 +0100 From: Sebastian Frias User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: =?windows-1252?Q?M=E5ns_Rullg=E5rd?= CC: "David S. Miller" , netdev@vger.kernel.org, LKML , mason Subject: Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver References: <56B4A445.7080402@laposte.net> <56B4A877.4020800@laposte.net> <56B4ACC4.1000607@laposte.net> <56B4B013.5030407@laposte.net> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-VR-SrcIP: 83.142.147.193 X-VR-FullState: 0 X-VR-Score: -100 X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeekjedrvddvgdeilecutefuodetggdotefrodftvfcurfhrohhf X-VR-Cause-2: ihhlvgemucfntefrqffuvffgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhs X-VR-Cause-3: ucdlqddutddtmdenucfjughrpefkfffhfgggvffufhgjtgfgsehtkegrtddtfeehnecuhfhrohhmpefu X-VR-Cause-4: vggsrghsthhirghnucfhrhhirghsuceoshhfkeegsehlrghpohhsthgvrdhnvghtqeenucfrrghrrghm X-VR-Cause-5: pehmohguvgepshhmthhpohhuthdphhgvlhhopegludejvddrvdejrddtrddvudegngdpihhnvghtpeek X-VR-Cause-6: fedrudegvddrudegjedrudelfedpmhgrihhlfhhrohhmpehsfhekgeeslhgrphhoshhtvgdrnhgvthdp X-VR-Cause-7: rhgtphhtthhopehmrghnshesmhgrnhhsrhdrtghomh X-VR-AvState: No X-VR-State: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/05/2016 03:34 PM, Måns Rullgård wrote: > Sebastian Frias writes: > >> Signed-off-by: Sebastian Frias > > Please change the subject to something like "net: ethernet: nb8800: > support fixed-link DT node" and add a comment body. The subject is pretty explicit for such a simple patch, what else could I add that wouldn't be unnecessary chat? > >> --- >> drivers/net/ethernet/aurora/nb8800.c | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/aurora/nb8800.c >> b/drivers/net/ethernet/aurora/nb8800.c >> index ecc4a33..e1fb071 100644 >> --- a/drivers/net/ethernet/aurora/nb8800.c >> +++ b/drivers/net/ethernet/aurora/nb8800.c >> @@ -1460,7 +1460,19 @@ static int nb8800_probe(struct platform_device *pdev) >> goto err_disable_clk; >> } >> >> - priv->phy_node = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0); >> + if (of_phy_is_fixed_link(pdev->dev.of_node)) { >> + ret = of_phy_register_fixed_link(pdev->dev.of_node); >> + if (ret < 0) { >> + dev_err(&pdev->dev, "bad fixed-link spec\n"); >> + goto err_free_bus; >> + } >> + priv->phy_node = of_node_get(pdev->dev.of_node); >> + } >> + >> + if (!priv->phy_node) >> + priv->phy_node = of_parse_phandle(pdev->dev.of_node, >> + "phy-handle", 0); >> + >> if (!priv->phy_node) { >> dev_err(&pdev->dev, "no PHY specified\n"); >> ret = -ENODEV; >> -- >> 2.1.4 >