From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 30/30] tools/libxc: Calculate xstate cpuid leaf from guest information Date: Fri, 5 Feb 2016 15:22:23 +0000 Message-ID: <56B4BE2F.2090701@citrix.com> References: <1454679743-18133-1-git-send-email-andrew.cooper3@citrix.com> <1454679743-18133-31-git-send-email-andrew.cooper3@citrix.com> <56B4BFA202000078000CF1C7@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56B4BFA202000078000CF1C7@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Jackson , Wei Liu , Ian Campbell , Xen-devel List-Id: xen-devel@lists.xenproject.org On 05/02/16 14:28, Jan Beulich wrote: >>>> On 05.02.16 at 14:42, wrote: >> --- a/tools/libxc/xc_cpuid_x86.c >> +++ b/tools/libxc/xc_cpuid_x86.c >> @@ -380,6 +380,11 @@ static void intel_xc_cpuid_policy(xc_interface *xch, >> } >> } >> >> +#define X86_XCR0_X87 (1ULL << 0) >> +#define X86_XCR0_SSE (1ULL << 1) >> +#define X86_XCR0_AVX (1ULL << 2) >> +#define X86_XCR0_LWP (1ULL << 62) > What about all the other bits we meanwhile know? These are the only ones used. ... which leads me to wonder where MPX support went. I think I may have accidentally lost it in the rebase. ~Andrew