From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRmRD-0005xu-9a for qemu-devel@nongnu.org; Fri, 05 Feb 2016 14:53:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRmRC-0007E0-B0 for qemu-devel@nongnu.org; Fri, 05 Feb 2016 14:53:03 -0500 References: <1453311539-1193-1-git-send-email-berrange@redhat.com> <1453311539-1193-10-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <56B4FD96.4030008@redhat.com> Date: Fri, 5 Feb 2016 12:52:54 -0700 MIME-Version: 1.0 In-Reply-To: <1453311539-1193-10-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CcivlBOL702c7rO3PX8W6ajg29lrFLArD" Subject: Re: [Qemu-devel] [PATCH v2 09/17] qemu-img/qemu-io: don't prompt for passwords if not required List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CcivlBOL702c7rO3PX8W6ajg29lrFLArD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > The qemu-img/qemu-io tools prompt for disk encryption passwords > regardless of whether any are actually required. Adding a check > on bdrv_key_required() avoids this prompt for disk formats which > have been converted to the QCryptoSecret APIs. >=20 > This is just a temporary hack to ensure the block I/O tests > continue to work after each patch, since the last patch will > completely delete all the password prompting code. >=20 > Signed-off-by: Daniel P. Berrange > --- > qemu-img.c | 3 ++- > qemu-io.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CcivlBOL702c7rO3PX8W6ajg29lrFLArD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWtP2WAAoJEKeha0olJ0Nq/FEH+weeIQM0WIElRieGbfyXZfy4 hRUfDJGi9TzBMWLI9VoyiwqiBRNiAXLnGevY1+ixepLVbY/xJjDe26JW9zeFdY84 M7X7xMc4CL46DZurDPiWgqtBElcETTWDZwv1M+qWJM974fJgawbCpN3yU5aMeGtO cFn4n3YbEzRhzkMWwl3yDA8qbwqDu0SzCCxPnEQbtLDZsxbABzdVk55+07YB0kBX 3SGWOUsrsmzI7VnbhcNw4OEH374EBVbSIaSMLVX3PWus3pAeRtU5u0ycUK2Rj/rr CQ7+MYL/XvjHnXYLetwAqA+Lj6czO1P/DzR1v4icXOA9XG0VrfYHbiM24cYgiPo= =RGdo -----END PGP SIGNATURE----- --CcivlBOL702c7rO3PX8W6ajg29lrFLArD--