From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRmUx-0007JG-Nt for qemu-devel@nongnu.org; Fri, 05 Feb 2016 14:56:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRmUw-0007ui-Na for qemu-devel@nongnu.org; Fri, 05 Feb 2016 14:56:55 -0500 References: <1454695953-14710-1-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <56B4FE80.3090202@redhat.com> Date: Fri, 5 Feb 2016 12:56:48 -0700 MIME-Version: 1.0 In-Reply-To: <1454695953-14710-1-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4F4cNQktjiv9SXoAFFTu86kt2U34dCMBf" Subject: Re: [Qemu-devel] [PATCH v2] qemu-img: initialize MapEntry object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4F4cNQktjiv9SXoAFFTu86kt2U34dCMBf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/05/2016 11:12 AM, John Snow wrote: > Commit 16b0d555 introduced an issue where we are not initializing > has_filename for the 'next' MapEntry object, which leads to interesting= > errors in Valgrind and Clang -fsanitize=3Dundefined both. grammar: errors in both Valgrind and Clang -fsanitize=3Dundefined. >=20 > Zero the stack object at allocation AND make sure the utility to > populate the fields properly marks has_filename as false if applicable.= >=20 > Signed-off-by: John Snow > --- > v2: Initialize with a compound literal as a future-proofing measure. >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4F4cNQktjiv9SXoAFFTu86kt2U34dCMBf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWtP6AAAoJEKeha0olJ0Nq4s4IAIZv7kTGkgo7uktbZx7dmFED aRQ0dNWxbmJtfeA/pgxByxhBTZfG5Nig6bFryvnKqAQ3vN/cWYlR8YoTo8fYHRm5 B7ufMTBrK1+7jbvFXkaVMmOw8q1J9TAye2j7XCXiQx6yve8jDoR2AIDwCnM6drwp j26jECFZDwiC6sFa69zUa52KBfCerKvvIr3zWtHGFJ7swCpd99L6P78Idm113tHh nyyhKNFHZTqmSYaPHwVZJw0KoAYxUZeavs3+IuQF5kydi3VlfqgndGTROuR08JIO DPJGLO9BQUTKe8K9CElj9leM+JCe+zI0FuIQRQjMUusESjl7JwognKyF3vsqpPM= =WOd/ -----END PGP SIGNATURE----- --4F4cNQktjiv9SXoAFFTu86kt2U34dCMBf--