From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37686)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aRr6K-0002B0-OQ
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 19:51:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aRr6H-0008Kb-Ib
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 19:51:48 -0500
Received: from mail-qg0-x243.google.com ([2607:f8b0:400d:c04::243]:35050)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aRr6H-0008KX-Dp
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 19:51:45 -0500
Received: by mail-qg0-x243.google.com with SMTP id b35so5100594qge.2
	for <qemu-devel@nongnu.org>; Fri, 05 Feb 2016 16:51:45 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1453832250-766-1-git-send-email-peter.maydell@linaro.org>
	<1453832250-766-16-git-send-email-peter.maydell@linaro.org>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <56B5439C.6000309@twiddle.net>
Date: Sat, 6 Feb 2016 11:51:40 +1100
MIME-Version: 1.0
In-Reply-To: <1453832250-766-16-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 15/37] tcg: Clean up includes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org

On 01/27/2016 05:17 AM, Peter Maydell wrote:
> diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
> index 0ed10a9..8467d5d 100644
> --- a/tcg/aarch64/tcg-target.c
> +++ b/tcg/aarch64/tcg-target.c
> @@ -10,6 +10,7 @@
>    * See the COPYING file in the top-level directory for details.
>    */
>
> +#include "qemu/osdep.h"
>   #include "tcg-be-ldst.h"
>   #include "qemu/bitops.h"
>
> diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
> index 3edf6a6..146ac00 100644
> --- a/tcg/arm/tcg-target.c
> +++ b/tcg/arm/tcg-target.c
> @@ -22,6 +22,7 @@
>    * THE SOFTWARE.
>    */
>
> +#include "qemu/osdep.h"
>   #include "elf.h"
>   #include "tcg-be-ldst.h"
>
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index 9187d34..d90636c 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -22,6 +22,7 @@
>    * THE SOFTWARE.
>    */
>
> +#include "qemu/osdep.h"
>   #include "tcg-be-ldst.h"
>
>   #ifndef NDEBUG

Nack to these, and the others like them.
These files are not standalone, they are
included into tcg.c, so we ought not be
re-including qemu/osdep.h here.


> diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
> index 79e052f..2dc4998 100644
> --- a/tcg/mips/tcg-target.c
> +++ b/tcg/mips/tcg-target.c
> @@ -1735,7 +1736,6 @@ static int tcg_target_callee_save_regs[] = {
>   /* The Linux kernel doesn't provide any information about the available
>      instruction set. Probe it using a signal handler. */
>
> -#include <signal.h>
>
>   #ifndef use_movnz_instructions
>   bool use_movnz_instructions = false;

But this is good.

> diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c
> index 2c72565..c593344 100644
> --- a/tcg/ppc/tcg-target.c
> +++ b/tcg/ppc/tcg-target.c
> @@ -2725,8 +2726,6 @@ static void __attribute__((constructor)) tcg_cache_init(void)
>   }
>
>   #elif defined __APPLE__
> -#include <stdio.h>
> -#include <sys/types.h>
>   #include <sys/sysctl.h>
>
>   static void __attribute__((constructor)) tcg_cache_init(void)
> @@ -2745,11 +2744,6 @@ static void __attribute__((constructor)) tcg_cache_init(void)
>   }
>
>   #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> -#include <errno.h>
> -#include <stdio.h>
> -#include <stdlib.h>
> -#include <string.h>
> -#include <sys/types.h>
>   #include <sys/sysctl.h>
>
>   static void __attribute__((constructor)) tcg_cache_init(void)

And this.


r~