From: Arjan van de Ven <arjan@linux.intel.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
lkml <linux-kernel@vger.kernel.org>,
Ruchi Kandoi <kandoiruchi@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Oren Laadan <orenl@cellrox.com>,
Rom Lemarchand <romlem@android.com>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread.
Date: Fri, 5 Feb 2016 18:54:33 -0800 [thread overview]
Message-ID: <56B56069.5050904@linux.intel.com> (raw)
In-Reply-To: <CALAqxLX6vNdowBEiJ2DtcUiCRrwSe7dDhCJQ=U7476xTKf20FA@mail.gmail.com>
>> and most of the RT guys would only tolerate a little bit of it
>>
>> is there any real/practial use of going longer than 4 seconds? if there
>> is then yeah fixing it makes sense.
>> if it's just theoretical... shrug... 32 bit systems have a bunch of
>> other limits/differences a well.
>
> So I'd think it would be mostly theoretical, but in my testing on a
> VM, setting the timerslack for bash to 10 secs made time sleep 1 take
> ~10.5 seconds. So its apparently not too hard to coalesce fairly far
> out (I need to spend a bit more time to verify that events really
> weren't happening during that time and we're not just doing
> unnecessary delays with the extra slack).
99% sure you're hitting something else;
we look pretty much only 1 ahead in the queue for timers to run to see if
they can be run, once we hit a timer that's not ready yet we stop.
your 10 second ahead is behind a whole bunch of other not-ready ones
so won't even be looked at until its close
> But yea. My main concern is that if we do a consistent 64bit interface
> for all arches in the /proc/<pid>/timerslack_ns interface, it will
> make PR_GET_TIMERSLACK return incorrect results on 32bit systems when
> the slack is >= 2^32.
or we return UINT_MAX for that case. not too hard.
prev parent reply other threads:[~2016-02-06 2:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 18:08 [PATCH] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread John Stultz
2016-02-05 20:10 ` Kees Cook
2016-02-05 20:18 ` John Stultz
2016-02-05 20:13 ` Andrew Morton
2016-02-05 20:23 ` John Stultz
2016-02-05 20:32 ` Andrew Morton
2016-02-05 20:39 ` John Stultz
2016-02-05 20:44 ` Kees Cook
2016-02-05 20:50 ` Andrew Morton
2016-02-05 22:35 ` John Stultz
2016-02-06 0:51 ` John Stultz
2016-02-06 1:56 ` Andrew Morton
2016-02-06 2:41 ` John Stultz
2016-02-06 2:15 ` Arjan van de Ven
2016-02-06 2:50 ` John Stultz
2016-02-06 2:54 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B56069.5050904@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=john.stultz@linaro.org \
--cc=kandoiruchi@google.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orenl@cellrox.com \
--cc=romlem@android.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.