From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH v3 2/3] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access Date: Sat, 6 Feb 2016 09:09:18 +0200 Message-ID: <56B59C1E.5090101@bitdefender.com> References: <1454707342-14479-1-git-send-email-tlengyel@novetta.com> <1454707342-14479-2-git-send-email-tlengyel@novetta.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aRwzj-00054E-MJ for xen-devel@lists.xenproject.org; Sat, 06 Feb 2016 07:09:23 +0000 Received: from smtp03.buh.bitdefender.org (unknown [10.17.80.77]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id 2675D7FBD8 for ; Sat, 6 Feb 2016 09:09:20 +0200 (EET) In-Reply-To: <1454707342-14479-2-git-send-email-tlengyel@novetta.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , xen-devel@lists.xenproject.org Cc: Keir Fraser , Ian Campbell , Stefano Stabellini , George Dunlap , Andrew Cooper , Ian Jackson , Stefano Stabellini , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 02/05/2016 11:22 PM, Tamas K Lengyel wrote: > The altp2m subsystem in its current form duplicates much of the existing > code present in p2m for setting mem_access permissions. In this patch we > consolidate the two versions but keep the separate MEMOP and HVMOP interfaces. > > Signed-off-by: Tamas K Lengyel > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Razvan Cojocaru > Cc: Stefano Stabellini > Cc: Keir Fraser > Cc: Jan Beulich > Cc: Andrew Cooper > Cc: George Dunlap > Acked-by: Wei Liu > --- > v3: Keep the external-facing interfaces and tools as they are > Pass gfn_t and make p2m_set_altp2m_mem_access inline > Remove goto and just return rc directly > v2: Don't deprecate the HVMOP hypercall for setting mem_access > Use unsigned int instead of unsigned long > --- > xen/arch/arm/p2m.c | 9 +-- > xen/arch/x86/hvm/hvm.c | 6 +- > xen/arch/x86/mm/p2m.c | 168 +++++++++++++++++++------------------------ > xen/common/mem_access.c | 2 +- > xen/include/asm-x86/p2m.h | 4 -- > xen/include/xen/p2m-common.h | 3 +- > 6 files changed, 86 insertions(+), 106 deletions(-) Acked-by: Razvan Cojocaru Thanks, Razvan