From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH v3 3/3] altp2m: Implement p2m_get_mem_access for altp2m views Date: Sat, 6 Feb 2016 12:48:53 +0200 Message-ID: <56B5CF95.2090705@bitdefender.com> References: <1454707342-14479-1-git-send-email-tlengyel@novetta.com> <1454707342-14479-3-git-send-email-tlengyel@novetta.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aS0QD-00043X-Nq for xen-devel@lists.xenproject.org; Sat, 06 Feb 2016 10:48:57 +0000 Received: from smtp03.buh.bitdefender.org (unknown [10.17.80.77]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id 55DFB7FBD7 for ; Sat, 6 Feb 2016 12:48:54 +0200 (EET) In-Reply-To: <1454707342-14479-3-git-send-email-tlengyel@novetta.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , xen-devel@lists.xenproject.org Cc: Wei Liu , Ian Campbell , Stefano Stabellini , George Dunlap , Andrew Cooper , Ian Jackson , Stefano Stabellini , Jan Beulich , Keir Fraser List-Id: xen-devel@lists.xenproject.org On 02/05/2016 11:22 PM, Tamas K Lengyel wrote: > Extend the existing get_mem_access memop to allow querying permissions in > altp2m views as well. > > Signed-off-by: Tamas K Lengyel > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Wei Liu > Cc: Razvan Cojocaru > Cc: Stefano Stabellini > Cc: George Dunlap > Cc: Keir Fraser > Cc: Jan Beulich > Cc: Andrew Cooper > --- > v3: Define a union over a memop field for the separate use during get and set > v2: Use unsigned int instead of unsigned long > Use a single p2m pointer > --- > tools/libxc/include/xenctrl.h | 3 ++- > tools/libxc/xc_mem_access.c | 10 ++++++---- > tools/tests/xen-access/xen-access.c | 5 ++++- > xen/arch/arm/p2m.c | 4 ++-- > xen/arch/x86/mm/p2m.c | 17 +++++++++++++++-- > xen/common/mem_access.c | 10 +++++----- > xen/include/public/memory.h | 19 ++++++++++++++----- > xen/include/xen/p2m-common.h | 3 ++- > 8 files changed, 50 insertions(+), 21 deletions(-) Acked-by: Razvan Cojocaru Took a bit longer on this one because I wanted to do a test run with our application after applying these last two patches and make sure things work. They seem to work.