From: Guenter Roeck <linux@roeck-us.net>
To: Josh Cartwright <joshc@ni.com>, Kyle Roeschley <kyle.roeschley@ni.com>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org
Subject: Re: [RFC 2/4] watchdog: ni9x3x_wdt: Add counter sysfs attribute
Date: Sat, 6 Feb 2016 08:35:06 -0800 [thread overview]
Message-ID: <56B620BA.8000009@roeck-us.net> (raw)
In-Reply-To: <20160205195336.GB9579@jcartwri.amer.corp.natinst.com>
On 02/05/2016 11:53 AM, Josh Cartwright wrote:
> On Thu, Feb 04, 2016 at 07:28:01PM -0600, Kyle Roeschley wrote:
>> The NI 9x3x watchdog timer has 30.72 µs resolution, so expose this
>> by allowing the user to set the timeout counter directly via a sysfs
>> attribute.
>
> But _why_? That isn't clear to me. Why do we want a user to directly
> muck with the counter value? (As opposed to working in units of time?).
>
In addition to that, this also messes up the watchdog core's notion of
wdd->timeout, meaning the watchdog subsystem would no longer report
the actually configured timeout value to user space.
Guenter
next prev parent reply other threads:[~2016-02-06 16:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 1:28 [RFC 1/4] watchdog: ni9x3x_wdt: Add NI 903x/913x watchdog driver Kyle Roeschley
2016-02-05 1:28 ` [RFC 2/4] watchdog: ni9x3x_wdt: Add counter sysfs attribute Kyle Roeschley
2016-02-05 19:53 ` Josh Cartwright
2016-02-06 16:35 ` Guenter Roeck [this message]
2016-02-05 1:28 ` [RFC 3/4] watchdog: ni9x3x_wdt: Add timeout_action " Kyle Roeschley
2016-02-05 20:08 ` Josh Cartwright
2016-02-05 21:13 ` Kyle Roeschley
2016-02-05 21:40 ` Josh Cartwright
2016-02-06 0:00 ` Guenter Roeck
2016-02-05 1:28 ` [RFC 4/4] watchdog: ni9x3x_wdt: Let user control watchdog mode Kyle Roeschley
2016-02-05 20:27 ` Josh Cartwright
2016-02-05 21:03 ` Kyle Roeschley
2016-02-05 21:34 ` Josh Cartwright
2016-02-06 16:42 ` Guenter Roeck
2016-02-05 19:49 ` [RFC 1/4] watchdog: ni9x3x_wdt: Add NI 903x/913x watchdog driver Josh Cartwright
2016-02-06 16:30 ` Guenter Roeck
2016-02-08 16:06 ` Kyle Roeschley
2016-02-06 16:33 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B620BA.8000009@roeck-us.net \
--to=linux@roeck-us.net \
--cc=joshc@ni.com \
--cc=kyle.roeschley@ni.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.