From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753012AbcBFV0E (ORCPT ); Sat, 6 Feb 2016 16:26:04 -0500 Received: from mail-oi0-f54.google.com ([209.85.218.54]:36287 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbcBFV0C (ORCPT ); Sat, 6 Feb 2016 16:26:02 -0500 Subject: Re: [PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs To: "Andrew F. Davis" , "David S . Miller" References: <1454713996-28851-1-git-send-email-afd@ti.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: <56B664E7.4040202@gmail.com> Date: Sat, 6 Feb 2016 13:25:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454713996-28851-1-git-send-email-afd@ti.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 05/02/2016 15:13, Andrew F. Davis a écrit : > The TI TLK10x Ethernet PHYs are similar in the interrupt relevant > registers and so are compatible with the DP83848x devices already > supported. Add these and re-order code to support additional PHYs. This looks fine, but this could also be broken down into 3 commits: - one which adds the macro to add new PHY entries - one which renames DP83848_PHY_ID to DP83848C_PHY_ID - one which factors out the interrupt enable mask > > Signed-off-by: Andrew F. Davis > --- > drivers/net/phy/dp83848.c | 89 ++++++++++++++++++++++++++++------------------- > 1 file changed, 53 insertions(+), 36 deletions(-) > > diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c > index 5e14e62..bc88259 100644 > --- a/drivers/net/phy/dp83848.c > +++ b/drivers/net/phy/dp83848.c > @@ -1,7 +1,8 @@ > /* > * Driver for the Texas Instruments DP83848 PHY > * > - * Copyright (C) 2015 Texas Instruments Inc. > + * Copyright (C) 2015-2016 Texas Instruments Incorporated - http://www.ti.com/ > + * Andrew F. Davis We have the git changelog to know who added changes to the driver, you can drop that specific change and just bump the copyright year.-- -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs Date: Sat, 6 Feb 2016 13:25:59 -0800 Message-ID: <56B664E7.4040202@gmail.com> References: <1454713996-28851-1-git-send-email-afd@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "Andrew F. Davis" , "David S . Miller" Return-path: In-Reply-To: <1454713996-28851-1-git-send-email-afd@ti.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Le 05/02/2016 15:13, Andrew F. Davis a =C3=A9crit : > The TI TLK10x Ethernet PHYs are similar in the interrupt relevant > registers and so are compatible with the DP83848x devices already > supported. Add these and re-order code to support additional PHYs. This looks fine, but this could also be broken down into 3 commits: - one which adds the macro to add new PHY entries - one which renames DP83848_PHY_ID to DP83848C_PHY_ID - one which factors out the interrupt enable mask >=20 > Signed-off-by: Andrew F. Davis > --- > drivers/net/phy/dp83848.c | 89 ++++++++++++++++++++++++++++---------= ---------- > 1 file changed, 53 insertions(+), 36 deletions(-) >=20 > diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c > index 5e14e62..bc88259 100644 > --- a/drivers/net/phy/dp83848.c > +++ b/drivers/net/phy/dp83848.c > @@ -1,7 +1,8 @@ > /* > * Driver for the Texas Instruments DP83848 PHY > * > - * Copyright (C) 2015 Texas Instruments Inc. > + * Copyright (C) 2015-2016 Texas Instruments Incorporated - http://w= ww.ti.com/ > + * Andrew F. Davis We have the git changelog to know who added changes to the driver, you can drop that specific change and just bump the copyright year.--