From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754000AbcBGOCv (ORCPT ); Sun, 7 Feb 2016 09:02:51 -0500 Received: from e38.co.us.ibm.com ([32.97.110.159]:41794 "EHLO e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753893AbcBGOCu (ORCPT ); Sun, 7 Feb 2016 09:02:50 -0500 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: xinhui.pan@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] tty/n_gsm.c: use gsm->num to remove mux itself from gsm_mux[] To: Greg Kroah-Hartman , Pan Xinhui References: <568B73FC.7020407@linux.vnet.ibm.com> <20160207072947.GA1214@kroah.com> Cc: linux-kernel@vger.kernel.org, Jiri Slaby , mnipxh@163.com, yanmin_zhang@linux.intel.com, alan@linux.intel.com From: Pan Xinhui Message-ID: <56B74E6E.50804@linux.vnet.ibm.com> Date: Sun, 7 Feb 2016 22:02:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160207072947.GA1214@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16020714-0029-0000-0000-0000104B3214 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, Greg thanks for your reply. On 2016/2/7 15:29, Greg Kroah-Hartman wrote: > On Tue, Jan 05, 2016 at 03:42:52PM +0800, Pan Xinhui wrote: >> From: Pan Xinhui >> >> There is one filed gsm->num to store mux's index of gsm_mux[]. So use >> gsm->num to remove itself from gsm_mux[] instead of the for-loop >> traverse in gsm_cleanup_mux(). >> >> Signed-off-by: Pan Xinhui >> Reviewed-by: Alan Cox >> --- >> change from V1: >> lock is also held for the if() >> --- >> drivers/tty/n_gsm.c | 13 +++++-------- >> 1 file changed, 5 insertions(+), 8 deletions(-) > > Doesn't apply to my tty-next branch of the tty.git tree :( > Sorry for not telling you one important information. This patch is on top of Jiri's patch, "TTY: n_gsm, fix false positive WARN_ON", see https://patchwork.kernel.org/patch/7692181/ Looks like Jiri's patch is still not in your tree. Hi, Jiri Could I make a new patch on top of the mainline's codes first then you prepare your patch on top of mine? I will appreciate that if you have a better solution :) thanks xinhui