From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754317AbcBGQpq (ORCPT ); Sun, 7 Feb 2016 11:45:46 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:55355 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbcBGQpo (ORCPT ); Sun, 7 Feb 2016 11:45:44 -0500 Subject: Re: [PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs To: Florian Fainelli , "David S . Miller" References: <1454713996-28851-1-git-send-email-afd@ti.com> <56B664E7.4040202@gmail.com> CC: , From: "Andrew F. Davis" Message-ID: <56B774B5.70603@ti.com> Date: Sun, 7 Feb 2016 10:45:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56B664E7.4040202@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/2016 03:25 PM, Florian Fainelli wrote: > Le 05/02/2016 15:13, Andrew F. Davis a écrit : >> The TI TLK10x Ethernet PHYs are similar in the interrupt relevant >> registers and so are compatible with the DP83848x devices already >> supported. Add these and re-order code to support additional PHYs. > > This looks fine, but this could also be broken down into 3 commits: > > - one which adds the macro to add new PHY entries > - one which renames DP83848_PHY_ID to DP83848C_PHY_ID > - one which factors out the interrupt enable mask > No problem, will do. >> >> Signed-off-by: Andrew F. Davis >> --- >> drivers/net/phy/dp83848.c | 89 ++++++++++++++++++++++++++++------------------- >> 1 file changed, 53 insertions(+), 36 deletions(-) >> >> diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c >> index 5e14e62..bc88259 100644 >> --- a/drivers/net/phy/dp83848.c >> +++ b/drivers/net/phy/dp83848.c >> @@ -1,7 +1,8 @@ >> /* >> * Driver for the Texas Instruments DP83848 PHY >> * >> - * Copyright (C) 2015 Texas Instruments Inc. >> + * Copyright (C) 2015-2016 Texas Instruments Incorporated - http://www.ti.com/ >> + * Andrew F. Davis > > We have the git changelog to know who added changes to the driver, you > can drop that specific change and just bump the copyright year. I was the original author and forgot to add this, just like the consistency with other drivers with named authors, but not a big deal so I can drop that. Andrew > -- > Florian >