All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@ozlabs.org>
To: openbmc@lists.ozlabs.org
Cc: Chris Austen <causten@users.noreply.github.com>
Subject: Re: [PATCH docs] Update dbus-interfaces.md for Event Log api
Date: Mon, 8 Feb 2016 16:54:58 +0800	[thread overview]
Message-ID: <56B857E2.9030306@ozlabs.org> (raw)
In-Reply-To: <1454565011-29416-2-git-send-email-openbmc-patches@stwcx.xyz>

Hi Chris,

> From: Chris Austen <causten@users.noreply.github.com>

You may want to set your git user settings there? I can fix it for this
change though...


> diff --git a/dbus-interfaces.md b/dbus-interfaces.md
> index 28fe410..db0f232 100644
> --- a/dbus-interfaces.md
> +++ b/dbus-interfaces.md
> @@ -151,4 +151,30 @@ properties:
>  
>    *  `state`
>  
> +# Event Logs
>  
> +## `/org/openbmc/records/events`
> +
> +methods:
> +
> +  *  `Clear()`

All of our other methods start with a lowercase, is this intentional?


> +
> +## `/org/openbmc/records/events/<logid>`
> +
> +methods:
> +
> +  *  `delete()`
> +
> +properties:
> +
> +  *  `message`
> +
> +  *  `association`
> +
> +  *  `reported_by`
> +
> +  *  `severity`
> +
> +  *  `debug_data`
> +
> +  *  `time`

Looks good.

Cheers,


Jeremy

      reply	other threads:[~2016-02-08  8:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04  5:50 [PATCH docs] Update dbus-interfaces.md for Event Log api OpenBMC Patches
2016-02-04  5:50 ` OpenBMC Patches
2016-02-08  8:54   ` Jeremy Kerr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B857E2.9030306@ozlabs.org \
    --to=jk@ozlabs.org \
    --cc=causten@users.noreply.github.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.