From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keerthy Subject: Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Date: Mon, 8 Feb 2016 15:18:12 +0530 Message-ID: <56B8645C.1050800@ti.com> References: <1453988331-17111-1-git-send-email-j-keerthy@ti.com> <1453988331-17111-2-git-send-email-j-keerthy@ti.com> <56AA232D.3040509@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56AA232D.3040509@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Grygorii Strashko , Keerthy , linus.walleij@linaro.org, Alexandre Courbot Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, lokeshvutla@ti.com, Santosh Shilimkar , Sekhar Nori List-Id: linux-gpio@vger.kernel.org On Thursday 28 January 2016 07:48 PM, Grygorii Strashko wrote: > On 01/28/2016 03:38 PM, Keerthy wrote: >> Currently the first parameter of irq_domain_add_legacy is NULL. >> irq_find_host function returns NULL when we do not populate the of_node >> and hence irq_of_parse_and_map call fails whenever we want to request a >> gpio irq. This fixes the request_irq failures for gpio interrupts. >> >> Signed-off-by: Keerthy > > Reviewed-by: Grygorii Strashko A gentle ping on this patch. Thanks Grygorii for the review. > >> --- >> drivers/gpio/gpio-davinci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c >> index ec58f42..c889f31 100644 >> --- a/drivers/gpio/gpio-davinci.c >> +++ b/drivers/gpio/gpio-davinci.c >> @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct >> platform_device *pdev) >> return irq; >> } >> >> - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0, >> + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0, >> &davinci_gpio_irq_ops, >> chips); >> if (!irq_domain) { >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752233AbcBHJsV (ORCPT ); Mon, 8 Feb 2016 04:48:21 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:52407 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbcBHJsS (ORCPT ); Mon, 8 Feb 2016 04:48:18 -0500 Subject: Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call To: Grygorii Strashko , Keerthy , , Alexandre Courbot References: <1453988331-17111-1-git-send-email-j-keerthy@ti.com> <1453988331-17111-2-git-send-email-j-keerthy@ti.com> <56AA232D.3040509@ti.com> CC: , , , Santosh Shilimkar , Sekhar Nori From: Keerthy Message-ID: <56B8645C.1050800@ti.com> Date: Mon, 8 Feb 2016 15:18:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56AA232D.3040509@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 28 January 2016 07:48 PM, Grygorii Strashko wrote: > On 01/28/2016 03:38 PM, Keerthy wrote: >> Currently the first parameter of irq_domain_add_legacy is NULL. >> irq_find_host function returns NULL when we do not populate the of_node >> and hence irq_of_parse_and_map call fails whenever we want to request a >> gpio irq. This fixes the request_irq failures for gpio interrupts. >> >> Signed-off-by: Keerthy > > Reviewed-by: Grygorii Strashko A gentle ping on this patch. Thanks Grygorii for the review. > >> --- >> drivers/gpio/gpio-davinci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c >> index ec58f42..c889f31 100644 >> --- a/drivers/gpio/gpio-davinci.c >> +++ b/drivers/gpio/gpio-davinci.c >> @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct >> platform_device *pdev) >> return irq; >> } >> >> - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0, >> + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0, >> &davinci_gpio_irq_ops, >> chips); >> if (!irq_domain) { >> > >