From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v7 0/5] Add mipi dsi support for rk3288 Date: Mon, 8 Feb 2016 15:42:04 +0530 Message-ID: <56B869F4.6090507@codeaurora.org> References: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Zhong , heiko@sntech.de, linux-rockchip@lists.infradead.org, mark.yao@rock-chips.com, treding@nvidia.com Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Kumar Gala , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGksCgpPbiAwMS8wNi8yMDE2IDA5OjMzIEFNLCBDaHJpcyBaaG9uZyB3cm90ZToKPgo+IFRoZSBy azMyODggTUlQSSBEU0kgaXMgYSBTeW5vcHN5cyBEZXNpZ25XYXJlIE1JUEkgRFNJIGhvc3QgY29u dHJvbGxlcgo+IElQLiBUaGlzIHNlcmllcyBhZGRzIHN1cHBvcnQgZm9yIGEgU3lub3BzeXMgRGVz aWduV2FyZSBNSVBJIERTSSBob3N0Cj4gY29udHJvbGxlciBEUk0gZHJpdmVyLgo+Cj4gVGhlIE1J UEkgRFNJIGZlYXR1cmUgaXMgdGVzdGVkIG9uIHJrMzI4OCBldmIgYm9hcmQsIGJhY2twb3J0IHRo ZW0gdG8KPiBjaHJvbWUgb3Mga2VybmVsIGNocm9tZV92My4xNCwgYW5kIGl0IGNhbiBkaXNwbGF5 IG5vcm1hbGx5Lgo+Cj4gVGhpcyBwYXRjaHNldCBpcyBiYXNlIG9uIHRoZSBwYXRjaHNldCBmcm9t IFlpbmcubGl1QGZyZWVzY2FsZS5jb20uCj4gPGh0dHA6Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMv ZHJpLWRldmVsL21zZzc3MTgxLmh0bWw+Cj4KPiBBY2NvcmRpbmcgdG8gdGhlIHN1Z2dlc3Rpb24g ZnJvbSBUaGllcnJ5LCBJIGhhdmUgZ2V0IHJpZCBvZiB0aGUgYnJpZGdlLAo+IGFuZCByZWdpc3Rl ciB0aGUgZW5jb2RlciAmIGNvbm5lY3RlciBpbiBkcm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYy4K CkkndmUgcmFpc2VkIHRoaXMgcXVlc3Rpb24gdG9vIGxhdGUsIGJ1dCB3aGF0IHdhcyB0aGUgcmVh c29uIHRvIG5vdAppbXBsZW1lbnQgdGhlIERTSSBibG9jayBhcyBhIGJyaWRnZSBkcml2ZXI/CgpU aGUgZHJtL2hpc2lsaWNvbiBJUCBzZWVtcyB0byB1c2UgYSB2ZXJ5IHNpbWlsYXIgRFNJIERlc2ln bndhcmUgSVAgKHRoZQpyZWdpc3RlciBvZmZzZXRzIHNlZW1zIHRvIGJlIHRoZSBzYW1lKS4gVGhl cmUgaXMgYSBnb29kIHBvdGVudGlhbCBvZgpyZS11c2UgaGVyZSBieSBkaWZmZXJlbnQga21zIGRy aXZlcnMgaGVyZSB0aGUgd2F5IGl0J3MgYWxyZWFkeSBkb25lIGZvcgpEVyBIRE1JIGFuZCB0aGUg YW5hbG9naXggRFAgZHJpdmVyIHRoYXQncyBpbiByZXZpZXcgcHJvY2Vzcy4KCkFyY2hpdAoKPiBB ZnRlciBiYWNrcG9ydCBiZWxvdyBwYXRjaGVzIGZyb20gbGludXgtbmV4dCwgSSBjYW4gbWVyZ2Ug dGhpcyBzZXJpYWwgaW50bwo+IERhdmUncyBkcm0tbmV4dCBicmFuY2guCj4KPiA5NGQ1ZDZhMGZi ZjMgY2xrOiByb2NrY2hpcDogYWRkIGFuIGlkIGZvciByazMyODggY3J5cHRvIGNsawo+IGM2ZDQ5 ZmJjZmNjNCBjbGs6IHJvY2tjaGlwOiBhZGQgaWQgZm9yIG1pcGlkc2kgc2NsayBvbiByazMyODgK PiBhMmY0YzU2MGYxOGUgY2xrOiByb2NrY2hpcDogYWRkIG1pcGlkc2kgY2xvY2sgb24gcmszMjg4 Cj4gNjljOTIzNzQzNjQwIEFSTTogZHRzOiByb2NrY2hpcDogY29ycmVjdCB0aGUgbmFtZSBvZiBS RUc4IGZvciByazMyODgtZXZiLWFjdDg4NDYKPiA2NjI1MTNhMTRjOWQgQVJNOiBkdHM6IHJvY2tj aGlwOiBhZGQgMiByZWd1bGF0b3JzIGZvciByazMyODgtZXZiLWFjdDg4NDYKPiBiMDQwNjFlNjU5 OWIgQVJNOiBkdHM6IHJvY2tjaGlwOiBtb3ZlIHRoZSBwdWJsaWMgcGFydCB0byByazMyODgtZXZi IGNvbW1vbgo+Cj4KPiBDaGFuZ2VzIGluIHY3Ogo+IC0gbW9kaWZ5IHRoZSBjb25maWcgdG8gdHJp c3RhdGUgZm9yIG1vZHVsZXMgYnVpbGQgKE1hcmsgWWFvKQo+IC0gUGFzcyBOVUxMICduYW1lJyB0 byBkcm1fZW5jb2Rlcl9pbml0KCkgdG8gZml4IGNvbXBpbGUgZXJyIChNYXJrIFlhbykKPiAtIE1v dmUgdGhlIGxjZF9lbiBjb250cm9sIHRvIGFjdDg4NDYgZHRzCj4KPiBDaGFuZ2VzIGluIHY2Ogo+ IC0gdXBkYXRlIHRoZSBkb2N1bWVudCwgc2luY2UgdGhlIGJyaWRnZSBkZXZpY2UgaGFzIGJlZW4g ZGVsZXRlZC4KPiAtIG1vdmUgdGhlIG1pcGlfZW4gZ2F0ZSB0byBvY2tjaGlwX2RybV9jcnRjX21v ZGVfY29uZmlnCj4gLSBSZW1vdmUgdGhlIGF0b21pYyBmZWF0dXJlIGNoZWNrIChNYXJrIFlhbykK PiAtIEFkZCBhdG9taWMgQVBJIHN1cHBvcnQgKEhlaWtvIFN0w7xibmUpCj4gLSBEbyBub3QgdXNl IGJyaWRnZSBkcml2ZXIgKFRoaWVycnkgUmVkaW5nKQo+IC0gT3B0aW1pemF0aW9uIHRoZSBwaHkg aW5pdCBzZXF1ZW5jZQo+Cj4gQ2hhbmdlcyBpbiB2NToKPiAtIG1vZGlmeSB0aGUgY2xrIG5hbWUg dG8gU0NMS19NSVBJRFNJXzI0TQo+IC0gYWRkIGEgYmxhbmsgbGluZSBiZWZvciBsY2RfZW4KPgo+ IENoYW5nZXMgaW4gdjQ6Cj4gLSB1c2UgY2xrX3JvdW5kX3JhdGUgdG8gY2hlY2sgdGhlIGNsb2Nr IHJhdGUgaW4gdm9wX2NydGNfbW9kZV9maXh1cAo+Cj4gQ2hhbmdlcyBpbiB2MzoKPiAtIG1vdmUg ZHdfbWlwaV9kc2lfcm9ja2NoaXAudHh0IHRvIGJpbmRpbmdzL2Rpc3BsYXkvcm9ja2NoaXAvCj4K PiBDaHJpcyBaaG9uZyAoNSk6Cj4gICAgZHJtL3JvY2tjaGlwOiByZXR1cm4gYSB0cnVlIGNsb2Nr IHJhdGUgdG8gYWRqdXN0ZWRfbW9kZQo+ICAgIERvY3VtZW50YXRpb246IGR0LWJpbmRpbmdzOiBB ZGQgYmluZGluZ3MgZm9yIHJrMzI4OCBEVyBNSVBJIERTSSBkcml2ZXIKPiAgICBkcm06IHJvY2tj aGlwOiBTdXBwb3J0IFN5bm9wc3lzIERXIE1JUEkgRFNJCj4gICAgQVJNOiBkdHM6IHJvY2tjaGlw OiBhZGQgcmszMjg4IG1pcGlfZHNpIG5vZGVzCj4gICAgQVJNOiBkdHM6IHJvY2tjaGlwOiBhZGQg c3VwcG9ydCBtaXBpIHBhbmVsIHR2MDgwd3VtLW5sMAo+Cj4gICAuLi4vZGlzcGxheS9yb2NrY2hp cC9kd19taXBpX2RzaV9yb2NrY2hpcC50eHQgICAgICB8ICAgNjAgKwo+ICAgYXJjaC9hcm0vYm9v dC9kdHMvcmszMjg4LWV2Yi1hY3Q4ODQ2LmR0cyAgICAgICAgICAgfCAgICAyICsKPiAgIGFyY2gv YXJtL2Jvb3QvZHRzL3JrMzI4OC1ldmIuZHRzaSAgICAgICAgICAgICAgICAgIHwgICAxMiArLQo+ ICAgYXJjaC9hcm0vYm9vdC9kdHMvcmszMjg4LmR0c2kgICAgICAgICAgICAgICAgICAgICAgfCAg IDM5ICsKPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnICAgICAgICAgICAgICAg ICAgIHwgICAxMCArCj4gICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvTWFrZWZpbGUgICAgICAg ICAgICAgICAgICB8ICAgIDEgKwo+ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGkt ZHNpLmMgICAgICAgICAgICAgfCAxMTk2ICsrKysrKysrKysrKysrKysrKysrCj4gICBkcml2ZXJz L2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jICAgICAgICB8ICAgIDggKwo+ICAg OCBmaWxlcyBjaGFuZ2VkLCAxMzI3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAgIGNy ZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxh eS9yb2NrY2hpcC9kd19taXBpX2RzaV9yb2NrY2hpcC50eHQKPiAgIGNyZWF0ZSBtb2RlIDEwMDY0 NCBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYwo+CgotLSAKVGhlIFF1YWxj b21tIElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIHRoZSBDb2RlIEF1cm9y YSAKRm9ydW0sIGhvc3RlZCBieSBUaGUgTGludXggRm91bmRhdGlvbgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: architt@codeaurora.org (Archit Taneja) Date: Mon, 8 Feb 2016 15:42:04 +0530 Subject: [PATCH v7 0/5] Add mipi dsi support for rk3288 In-Reply-To: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> References: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> Message-ID: <56B869F4.6090507@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 01/06/2016 09:33 AM, Chris Zhong wrote: > > The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller > IP. This series adds support for a Synopsys DesignWare MIPI DSI host > controller DRM driver. > > The MIPI DSI feature is tested on rk3288 evb board, backport them to > chrome os kernel chrome_v3.14, and it can display normally. > > This patchset is base on the patchset from Ying.liu at freescale.com. > > > According to the suggestion from Thierry, I have get rid of the bridge, > and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c. I've raised this question too late, but what was the reason to not implement the DSI block as a bridge driver? The drm/hisilicon IP seems to use a very similar DSI Designware IP (the register offsets seems to be the same). There is a good potential of re-use here by different kms drivers here the way it's already done for DW HDMI and the analogix DP driver that's in review process. Archit > After backport below patches from linux-next, I can merge this serial into > Dave's drm-next branch. > > 94d5d6a0fbf3 clk: rockchip: add an id for rk3288 crypto clk > c6d49fbcfcc4 clk: rockchip: add id for mipidsi sclk on rk3288 > a2f4c560f18e clk: rockchip: add mipidsi clock on rk3288 > 69c923743640 ARM: dts: rockchip: correct the name of REG8 for rk3288-evb-act8846 > 662513a14c9d ARM: dts: rockchip: add 2 regulators for rk3288-evb-act8846 > b04061e6599b ARM: dts: rockchip: move the public part to rk3288-evb common > > > Changes in v7: > - modify the config to tristate for modules build (Mark Yao) > - Pass NULL 'name' to drm_encoder_init() to fix compile err (Mark Yao) > - Move the lcd_en control to act8846 dts > > Changes in v6: > - update the document, since the bridge device has been deleted. > - move the mipi_en gate to ockchip_drm_crtc_mode_config > - Remove the atomic feature check (Mark Yao) > - Add atomic API support (Heiko St?bne) > - Do not use bridge driver (Thierry Reding) > - Optimization the phy init sequence > > Changes in v5: > - modify the clk name to SCLK_MIPIDSI_24M > - add a blank line befor lcd_en > > Changes in v4: > - use clk_round_rate to check the clock rate in vop_crtc_mode_fixup > > Changes in v3: > - move dw_mipi_dsi_rockchip.txt to bindings/display/rockchip/ > > Chris Zhong (5): > drm/rockchip: return a true clock rate to adjusted_mode > Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver > drm: rockchip: Support Synopsys DW MIPI DSI > ARM: dts: rockchip: add rk3288 mipi_dsi nodes > ARM: dts: rockchip: add support mipi panel tv080wum-nl0 > > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 60 + > arch/arm/boot/dts/rk3288-evb-act8846.dts | 2 + > arch/arm/boot/dts/rk3288-evb.dtsi | 12 +- > arch/arm/boot/dts/rk3288.dtsi | 39 + > drivers/gpu/drm/rockchip/Kconfig | 10 + > drivers/gpu/drm/rockchip/Makefile | 1 + > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 1196 ++++++++++++++++++++ > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 8 + > 8 files changed, 1327 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > create mode 100644 drivers/gpu/drm/rockchip/dw-mipi-dsi.c > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752036AbcBHKMQ (ORCPT ); Mon, 8 Feb 2016 05:12:16 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43620 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438AbcBHKMN (ORCPT ); Mon, 8 Feb 2016 05:12:13 -0500 Subject: Re: [PATCH v7 0/5] Add mipi dsi support for rk3288 To: Chris Zhong , heiko@sntech.de, linux-rockchip@lists.infradead.org, mark.yao@rock-chips.com, treding@nvidia.com References: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Kumar Gala , linux-arm-kernel@lists.infradead.org, Xinliang Liu From: Archit Taneja Message-ID: <56B869F4.6090507@codeaurora.org> Date: Mon, 8 Feb 2016 15:42:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 01/06/2016 09:33 AM, Chris Zhong wrote: > > The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller > IP. This series adds support for a Synopsys DesignWare MIPI DSI host > controller DRM driver. > > The MIPI DSI feature is tested on rk3288 evb board, backport them to > chrome os kernel chrome_v3.14, and it can display normally. > > This patchset is base on the patchset from Ying.liu@freescale.com. > > > According to the suggestion from Thierry, I have get rid of the bridge, > and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c. I've raised this question too late, but what was the reason to not implement the DSI block as a bridge driver? The drm/hisilicon IP seems to use a very similar DSI Designware IP (the register offsets seems to be the same). There is a good potential of re-use here by different kms drivers here the way it's already done for DW HDMI and the analogix DP driver that's in review process. Archit > After backport below patches from linux-next, I can merge this serial into > Dave's drm-next branch. > > 94d5d6a0fbf3 clk: rockchip: add an id for rk3288 crypto clk > c6d49fbcfcc4 clk: rockchip: add id for mipidsi sclk on rk3288 > a2f4c560f18e clk: rockchip: add mipidsi clock on rk3288 > 69c923743640 ARM: dts: rockchip: correct the name of REG8 for rk3288-evb-act8846 > 662513a14c9d ARM: dts: rockchip: add 2 regulators for rk3288-evb-act8846 > b04061e6599b ARM: dts: rockchip: move the public part to rk3288-evb common > > > Changes in v7: > - modify the config to tristate for modules build (Mark Yao) > - Pass NULL 'name' to drm_encoder_init() to fix compile err (Mark Yao) > - Move the lcd_en control to act8846 dts > > Changes in v6: > - update the document, since the bridge device has been deleted. > - move the mipi_en gate to ockchip_drm_crtc_mode_config > - Remove the atomic feature check (Mark Yao) > - Add atomic API support (Heiko Stübne) > - Do not use bridge driver (Thierry Reding) > - Optimization the phy init sequence > > Changes in v5: > - modify the clk name to SCLK_MIPIDSI_24M > - add a blank line befor lcd_en > > Changes in v4: > - use clk_round_rate to check the clock rate in vop_crtc_mode_fixup > > Changes in v3: > - move dw_mipi_dsi_rockchip.txt to bindings/display/rockchip/ > > Chris Zhong (5): > drm/rockchip: return a true clock rate to adjusted_mode > Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver > drm: rockchip: Support Synopsys DW MIPI DSI > ARM: dts: rockchip: add rk3288 mipi_dsi nodes > ARM: dts: rockchip: add support mipi panel tv080wum-nl0 > > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 60 + > arch/arm/boot/dts/rk3288-evb-act8846.dts | 2 + > arch/arm/boot/dts/rk3288-evb.dtsi | 12 +- > arch/arm/boot/dts/rk3288.dtsi | 39 + > drivers/gpu/drm/rockchip/Kconfig | 10 + > drivers/gpu/drm/rockchip/Makefile | 1 + > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 1196 ++++++++++++++++++++ > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 8 + > 8 files changed, 1327 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > create mode 100644 drivers/gpu/drm/rockchip/dw-mipi-dsi.c > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation