From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 24/30] tools/libxc: Modify bitmap
 operations to take void pointers
Date: Mon, 8 Feb 2016 11:40:10 +0000
Message-ID: <56B87E9A.5050005@citrix.com>
References: <1454679743-18133-1-git-send-email-andrew.cooper3@citrix.com>
	<1454679743-18133-25-git-send-email-andrew.cooper3@citrix.com>
	<20160205161229.GE23178@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20160205161229.GE23178@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/02/16 16:12, Wei Liu wrote:
> On Fri, Feb 05, 2016 at 01:42:17PM +0000, Andrew Cooper wrote:
>> The type of the pointer to a bitmap is not interesting; it does not affect the
>> representation of the block of bits being pointed to.
>>
>> Make the libxc functions consistent with those in Xen, so they can work just
>> as well with 'unsigned int *' based bitmaps.
> I'm not sure I understand this, the bitmap functions in
> xen/include/bitmap.h seem to take unsigned long *.
>
> Not saying that I object to this patch, just this comment looks wrong.

The lower level bit operations <asm/bitops.h> are all in terms of void*,
for both x86 and arm

~Andrew