From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH] drm/exynos: dp: Fix panel and bridge lookup logic Date: Mon, 8 Feb 2016 09:03:36 -0300 Message-ID: <56B88418.7090106@osg.samsung.com> References: <1454080171-23769-1-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1454080171-23769-1-git-send-email-javier@osg.samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-kernel@vger.kernel.org, Inki Dae Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Jingoo Han , Seung-Woo Kim , dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org SGVsbG8gSW5raSwKCk9uIDAxLzI5LzIwMTYgMTI6MDkgUE0sIEphdmllciBNYXJ0aW5leiBDYW5p bGxhcyB3cm90ZToKPiBDb21taXQgYTlmYTg1Mjg4NmZkICgiZHJtL2V4eW5vczogZHA6IGFkZCBv Zl9ncmFwaCBkdCBiaW5kaW5nIHN1cHBvcnQKPiBmb3IgcGFuZWwiKSBtYWRlIHRoZSBFeHlub3Mg RFAgRFQgYmluZGluZyBtb3JlIGNvbnNpc3RlbnQgc2luY2UgdGhlIE9GCj4gZ3JhcGggY291bGQg YmUgdXNlZCB0byBsb29rdXAgZWl0aGVyIGEgcGFuZWwgb3IgYSBicmlkZ2UgZGV2aWNlIG5vZGUu Cj4KPiBCZWZvcmUgdGhhdCBjb21taXQsIGEgcGFuZWwgd291bGQgYmUgbG9va2VkIHVwIHVzaW5n IGEgcGhhbmRsZSBhbmQgYQo+IGJyaWRnZSB1c2luZyB0aGUgT0YgZ3JhcGggd2hpY2ggbWFkZSB0 aGUgRFQgYmluZGluZyBub3QgY29uc2lzdGVudC4KPgo+IEJ1dCB0aGUgcGF0Y2ggYnJva2UgdGhl IGxhdGVyIGNhc2Ugc2luY2Ugbm90IGZpbmRpbmcgYSBwYW5lbCBkZXYgbm9kZQo+IHdvdWxkIGNh dXNlIHRoZSBkcml2ZXIncyB0byBkbyBhIHByb2JlIGRlZmVycmFsIGluc3RlYWQgb2YgYXR0ZW1w dGluZwo+IHRvIGxvb2t1cCBhIGJyaWRnZSBkZXZpY2Ugbm9kZSBhc3NvY2lhdGVkIHdpdGggdGhl IHJlbW90ZSBlbmRwb2ludC4KPgo+IFNvIGluc3RlYWQgb2YgcmV0dXJuaW5nIGEgLUVQUk9CRV9E RUZFUiBpZiBhIHBhbmVsIGlzIG5vdCBmb3VuZCwgY2hlY2sKPiBpZiB0aGVyZSdzIGEgYnJpZGdl IGFuZCBvbmx5IGRvIGEgcHJvYmUgZGVmZXJyYWwgaWYgYm90aCBhcmVuJ3QgZm91bmQuCj4KPiBG aXhlczogYTlmYTg1Mjg4NmZkICgiZHJtL2V4eW5vczogZHA6IGFkZCBvZl9ncmFwaCBkdCBiaW5k aW5nIHN1cHBvcnQgZm9yIHBhbmVsIikKPiBTaWduZWQtb2ZmLWJ5OiBKYXZpZXIgTWFydGluZXog Q2FuaWxsYXMgPGphdmllckBvc2cuc2Ftc3VuZy5jb20+Cj4KCkFueSBjb21tZW50cyBhYm91dCB0 aGlzIHBhdGNoPyBJdCBpcyBuZWVkZWQgdG8gaGF2ZSBkaXNwbGF5IHdvcmtpbmcgb24KbWFjaGlu ZXMgd2l0aCBhIGJyaWRnZSBjaGlwIGFnYWluIHNvIGl0IHNob3VsZCBiZSBwdXNoZWQgdG8gLXJj IEFTQVAuCgpCZXN0IHJlZ2FyZHMsCi0tIApKYXZpZXIgTWFydGluZXogQ2FuaWxsYXMKT3BlbiBT b3VyY2UgR3JvdXAKU2Ftc3VuZyBSZXNlYXJjaCBBbWVyaWNhCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@osg.samsung.com (Javier Martinez Canillas) Date: Mon, 8 Feb 2016 09:03:36 -0300 Subject: [PATCH] drm/exynos: dp: Fix panel and bridge lookup logic In-Reply-To: <1454080171-23769-1-git-send-email-javier@osg.samsung.com> References: <1454080171-23769-1-git-send-email-javier@osg.samsung.com> Message-ID: <56B88418.7090106@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Inki, On 01/29/2016 12:09 PM, Javier Martinez Canillas wrote: > Commit a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support > for panel") made the Exynos DP DT binding more consistent since the OF > graph could be used to lookup either a panel or a bridge device node. > > Before that commit, a panel would be looked up using a phandle and a > bridge using the OF graph which made the DT binding not consistent. > > But the patch broke the later case since not finding a panel dev node > would cause the driver's to do a probe deferral instead of attempting > to lookup a bridge device node associated with the remote endpoint. > > So instead of returning a -EPROBE_DEFER if a panel is not found, check > if there's a bridge and only do a probe deferral if both aren't found. > > Fixes: a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support for panel") > Signed-off-by: Javier Martinez Canillas > Any comments about this patch? It is needed to have display working on machines with a bridge chip again so it should be pushed to -rc ASAP. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbcBHMDy (ORCPT ); Mon, 8 Feb 2016 07:03:54 -0500 Received: from lists.s-osg.org ([54.187.51.154]:35469 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbcBHMDw (ORCPT ); Mon, 8 Feb 2016 07:03:52 -0500 Subject: Re: [PATCH] drm/exynos: dp: Fix panel and bridge lookup logic To: linux-kernel@vger.kernel.org, Inki Dae References: <1454080171-23769-1-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , Krzysztof Kozlowski , Seung-Woo Kim , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, Kyungmin Park , Jingoo Han , David Airlie , Joonyoung Shim , linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <56B88418.7090106@osg.samsung.com> Date: Mon, 8 Feb 2016 09:03:36 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454080171-23769-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Inki, On 01/29/2016 12:09 PM, Javier Martinez Canillas wrote: > Commit a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support > for panel") made the Exynos DP DT binding more consistent since the OF > graph could be used to lookup either a panel or a bridge device node. > > Before that commit, a panel would be looked up using a phandle and a > bridge using the OF graph which made the DT binding not consistent. > > But the patch broke the later case since not finding a panel dev node > would cause the driver's to do a probe deferral instead of attempting > to lookup a bridge device node associated with the remote endpoint. > > So instead of returning a -EPROBE_DEFER if a panel is not found, check > if there's a bridge and only do a probe deferral if both aren't found. > > Fixes: a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support for panel") > Signed-off-by: Javier Martinez Canillas > Any comments about this patch? It is needed to have display working on machines with a bridge chip again so it should be pushed to -rc ASAP. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America