From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Henzl Subject: Re: [mpt3sas driver 07/10] mpt3sas: Add support for configurable Chain Frame Size Date: Mon, 8 Feb 2016 14:55:13 +0100 Message-ID: <56B89E41.5090500@redhat.com> References: <1453963027-19770-1-git-send-email-suganath-prabu.subramani@avagotech.com> <1453963027-19770-8-git-send-email-suganath-prabu.subramani@avagotech.com> <56B368C2.8080607@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sreekanth Reddy Cc: Suganath prabu Subaramani , "jejb@kernel.org" , Christoph Hellwig , "Martin K. Petersen" , "linux-scsi@vger.kernel.org" , Sathya Prakash , Kashyap Desai , Krishnaraddi Mankani , "linux-kernel@vger.kernel.org" , Chaitra Basappa , Sreekanth Reddy List-Id: linux-scsi@vger.kernel.org On 5.2.2016 08:56, Sreekanth Reddy wrote: > On Thu, Feb 4, 2016 at 8:35 PM, Tomas Henzl wrote: >> On 28.1.2016 07:37, Suganath prabu Subaramani wrote: >>> From: Suganath prabu Subramani >>> >>> Added support for configurable Chain Frame Size. Calculate the >>> Chain Message Frame size from the IOCMaxChainSegementSize (iocfacts). >>> Applicable only for mpt3sas/SAS3.0 HBA's. >>> >>> Signed-off-by: Suganath prabu Subramani >>> Signed-off-by: Chaitra P B >> Is this done in order to prepare for some future patch, or how does it work? >> I noticed only changes in allocation of (probably larger) fields, but >> how is it actually used ? > Tomas, > > In this patch set we have added new Intruder and Cutlass (high ports) > PCI devices which are based on MPI26 version. > In this MPI26 version, Request Frame size is doubled when compared to > older MPI version, but their is > no change in the Chain buffer size from MPI26 to older versions. In > older version Request frame size and > chain buffer size were same, so in the drivers previously we used to > use Request Frame size reference for > Chain buffer size. But we can't use that reference now. So now we are > determining the chain buffer size from > IOCFact's IOCMaxChainSegementSize field instead of using the Request > frame size reference. > > ~Sreekanth Thanks, Reviewed-by: Tomas Henzl Tomas