From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Mon, 8 Feb 2016 14:09:25 +0000 Subject: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO access In-Reply-To: <56B89F98.7020909@linaro.org> References: <71bf617f4083b116b2aeab24f13fc5fed99a816f.1454327031.git.robin.murphy@arm.com> <56B89F98.7020909@linaro.org> Message-ID: <56B8A195.2050807@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/02/16 14:00, Daniel Lezcano wrote: > On 02/01/2016 01:00 PM, Robin Murphy wrote: >> So far, we have been blindly assuming that having access to a >> memory-mapped timer frame implies that the individual elements of that >> frame frame are already enabled. Whilst it's the firmware's job to give >> us non-secure access to frames in the first place, we should not rely >> on implementations always being generous enough to also configure CNTACR >> for those non-secure frames (e.g. [1]). >> >> Explicitly enable feature-level access per-frame, and verify that the >> access we want is really implemented before trying to make use of it. >> >> [1]:https://github.com/ARM-software/tf-issues/issues/170 >> >> Signed-off-by: Robin Murphy >> --- > > Hi Marc, > > can you give your opinion on this patch ? This seems to do the right thing, so FWIW: Acked-by: Marc Zyngier Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbcBHOJa (ORCPT ); Mon, 8 Feb 2016 09:09:30 -0500 Received: from foss.arm.com ([217.140.101.70]:32803 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbcBHOJ2 (ORCPT ); Mon, 8 Feb 2016 09:09:28 -0500 Subject: Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO access To: Daniel Lezcano , Robin Murphy , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <71bf617f4083b116b2aeab24f13fc5fed99a816f.1454327031.git.robin.murphy@arm.com> <56B89F98.7020909@linaro.org> Cc: tglx@linutronix.de, mark.rutland@arm.com, sboyd@codeaurora.org From: Marc Zyngier Organization: ARM Ltd Message-ID: <56B8A195.2050807@arm.com> Date: Mon, 8 Feb 2016 14:09:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <56B89F98.7020909@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/16 14:00, Daniel Lezcano wrote: > On 02/01/2016 01:00 PM, Robin Murphy wrote: >> So far, we have been blindly assuming that having access to a >> memory-mapped timer frame implies that the individual elements of that >> frame frame are already enabled. Whilst it's the firmware's job to give >> us non-secure access to frames in the first place, we should not rely >> on implementations always being generous enough to also configure CNTACR >> for those non-secure frames (e.g. [1]). >> >> Explicitly enable feature-level access per-frame, and verify that the >> access we want is really implemented before trying to make use of it. >> >> [1]:https://github.com/ARM-software/tf-issues/issues/170 >> >> Signed-off-by: Robin Murphy >> --- > > Hi Marc, > > can you give your opinion on this patch ? This seems to do the right thing, so FWIW: Acked-by: Marc Zyngier Thanks, M. -- Jazz is not dead. It just smells funny...