From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754331AbcBHP0J (ORCPT ); Mon, 8 Feb 2016 10:26:09 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:33366 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753816AbcBHP0H (ORCPT ); Mon, 8 Feb 2016 10:26:07 -0500 Subject: Re: [tip:irq/core] genirq: Use a common macro to go through the actions list To: hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, linux-tip-commits@vger.kernel.org References: <1452765253-31148-1-git-send-email-daniel.lezcano@linaro.org> From: Daniel Lezcano Message-ID: <56B8B38B.1050401@linaro.org> Date: Mon, 8 Feb 2016 16:26:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2016 11:48 AM, tip-bot for Daniel Lezcano wrote: > Commit-ID: aff62cf66ad6065ce04fc3454a11ec19714537fb > Gitweb: http://git.kernel.org/tip/aff62cf66ad6065ce04fc3454a11ec19714537fb > Author: Daniel Lezcano > AuthorDate: Thu, 14 Jan 2016 10:54:13 +0100 > Committer: Thomas Gleixner > CommitDate: Mon, 8 Feb 2016 11:45:21 +0100 > > genirq: Use a common macro to go through the actions list > > The irq code browses the list of actions differently to inspect the element > one by one. Even if it is not a problem, for the sake of consistent code, > provide a macro similar to for_each_irq_desc in order to have the same loop to > go through the actions list and use it in the code. > > [ tglx: Renamed the macro ] > > Signed-off-by: Daniel Lezcano > Link: http://lkml.kernel.org/r/1452765253-31148-1-git-send-email-daniel.lezcano@linaro.org > Signed-off-by: Thomas Gleixner > --- > kernel/irq/handle.c | 5 ++--- > kernel/irq/internals.h | 3 +++ > kernel/irq/manage.c | 8 +++----- > kernel/irq/proc.c | 2 +- > kernel/irq/spurious.c | 4 +--- > 5 files changed, 10 insertions(+), 12 deletions(-) > > diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c > index 57bff78..67534d0 100644 > --- a/kernel/irq/handle.c > +++ b/kernel/irq/handle.c > @@ -136,10 +136,9 @@ irqreturn_t handle_irq_event_percpu(struct irq_desc *desc) > { > irqreturn_t retval = IRQ_NONE; > unsigned int flags = 0, irq = desc->irq_data.irq; > - struct irqaction *action = desc->action; > + struct irqaction *action; > > - /* action might have become NULL since we dropped the lock */ > - while (action) { > + for_each_action_of_desc(desc, action) { > irqreturn_t res; > > trace_irq_handler_entry(irq, action); The merge lost the removal of: action = action->next; resulting to the NULL pointer dereference bug spotted by 01.org. Do you want me to resend a new patch ? -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog