From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll
Date: Mon, 8 Feb 2016 16:34:16 +0100 [thread overview]
Message-ID: <56B8B578.6070208@redhat.com> (raw)
In-Reply-To: <20160205175149.GA797@stefanha-x1.localdomain>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 05/02/2016 18:51, Stefan Hajnoczi wrote:
>> Because this is a file descriptor source, there is really no
>> difference between the code's behavior, no matter if aio_poll
>> starts before or after the event_notifier_set. The test passes
>> even if you remove the sleep.
>>
>> Do you have any suggestion? Just add a comment?
>
> How about removing the sleep and adding a comment explaining that
> the event_notifier_set() could happen either before or during
> poll()?
Okay.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJWuLV0AAoJEL/70l94x66DajUIAIddRKfy4S45hUQmz9XUTbhA
cWfq7SWKjRB7FQSTM2rGDgDCvxDA1MejaIgde3GEMYRQcOj3yZgS8oSvDLXR8Eny
Y71Ir/kyjbqVEgjnZwN/1g7gULoS/dZCI/rXgjFjxhe3TC9Pwp6Gp6d6+vlnWRWM
c0a1xSwXpbnfLthozgz4eHD7d0u77/Ph7WCyU/2VYI09xKnAel+sIELzrFUhOYcc
us4/6tYE1YT0ZagpLkVHXdWbJK30d8tqSU+tBCrW6L/Ql8TAUjwbufaYZpCFBBiL
lF1Aif4q3Bg3iCohq4gRSf+96gp2GpIowJKqIJg0BpT9Z5XI/xRRzUeIq9eLbMM=
=zN4i
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2016-02-08 15:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 15:12 [Qemu-devel] [PATCH 00/16] aio: first part of aio_context_acquire/release pushdown Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 01/16] aio: introduce aio_context_in_iothread Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 02/16] aio: do not really acquire/release the main AIO context Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 03/16] aio: introduce aio_poll_internal Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 04/16] aio: only call aio_poll_internal from iothread Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll Paolo Bonzini
2016-02-02 14:52 ` Stefan Hajnoczi
2016-02-02 15:01 ` Paolo Bonzini
2016-02-03 9:34 ` Stefan Hajnoczi
2016-02-03 9:52 ` Paolo Bonzini
2016-02-05 17:51 ` Stefan Hajnoczi
2016-02-08 15:34 ` Paolo Bonzini [this message]
2016-01-15 15:12 ` [Qemu-devel] [PATCH 06/16] qemu-thread: introduce QemuRecMutex Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 07/16] aio: convert from RFifoLock to QemuRecMutex Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 08/16] aio: rename bh_lock to list_lock Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 09/16] qemu-thread: introduce QemuLockCnt Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 10/16] aio: make ctx->list_lock a QemuLockCnt, subsuming ctx->walking_bh Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 11/16] qemu-thread: optimize QemuLockCnt with futexes on Linux Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 12/16] aio: tweak walking in dispatch phase Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 13/16] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 14/16] aio-win32: " Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 15/16] aio: document locking Paolo Bonzini
2016-01-15 15:12 ` [Qemu-devel] [PATCH 16/16] aio: push aio_context_acquire/release down to dispatching Paolo Bonzini
2016-02-02 9:41 ` [Qemu-devel] [PATCH 00/16] aio: first part of aio_context_acquire/release pushdown Paolo Bonzini
2016-02-02 17:26 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2016-02-08 16:14 [Qemu-devel] [PATCH v2 " Paolo Bonzini
2016-02-08 16:14 ` [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll Paolo Bonzini
2016-02-09 11:45 [Qemu-devel] [PATCH v3 00/16] aio: first part of aio_context_acquire/release pushdown Paolo Bonzini
2016-02-09 11:46 ` [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8B578.6070208@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.