From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Charles (Chas) Williams" <ciwillia@brocade.com>
Subject: Re: [PATCH 1/2] bnx2x: fix error handling in
	bnx2x_loop_obtain_resources()
Date: Mon, 8 Feb 2016 07:53:46 -0800
Message-ID: <56B8BA0A.9050100@brocade.com>
References: <1451522271-16924-1-git-send-email-3chas3@gmail.com>
 <20160208135101.GA13952@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, sony.chacko@qlogic.com
To: Bruce Richardson <bruce.richardson@intel.com>, Chas Williams
 <3chas3@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com
 [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id 0527F2E83
 for <dev@dpdk.org>; Mon,  8 Feb 2016 16:53:51 +0100 (CET)
In-Reply-To: <20160208135101.GA13952@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

I am afraid I don't understand what you are asking. This was broken in 
the commit that added bnx2x, 540a211084a7695a1c7bc43068934c140d6989be

On 02/08/2016 05:51 AM, Bruce Richardson wrote:
> On Wed, Dec 30, 2015 at 07:37:50PM -0500, Chas Williams wrote:
>> From: "Charles (Chas) Williams" <ciwillia@brocade.com>
>>
>> bnx2x_loop_obtain_resources() returns a struct containing the status and
>> the error message.  If bnx2x_do_req4pf() fails, it shouldn't return both
>> of these fields set to 0 indicating failure and no error.
>>
>> Further, bnx2x_do_req4pf() needs to be able fail and return NO_RESOURCES
>> so that bnx2x_loop_obtain_resources() can negotiate reduced resource
>> requirments.  This requires additional checking around bnx2x_do_req4pf().
>>
>> Signed-off-by: Chas Williams <3chas3@gmail.com>
>> ---
>
> Hi Chas,
>
> can you please provide a commit reference for a fixes line for this patch. [No
> need for a V2 just for that alone, just the reference is enough to save me
> diving into the git history. I'll manually add the fixes line when committing
> to the next-net tree]
>
> Maintainers, can you please review this patchset and provide feedback or an ACK.
>
> Regards,
> /Bruce
>