From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corneliu ZUZU Subject: Re: [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c Date: Mon, 8 Feb 2016 19:12:30 +0200 Message-ID: <56B8CC7E.2040309@bitdefender.com> References: <1454950682-9459-1-git-send-email-czuzu@bitdefender.com> <1454950682-9459-2-git-send-email-czuzu@bitdefender.com> <56B8CA95.2010108@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56B8CA95.2010108@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , xen-devel@lists.xen.org Cc: Kevin Tian , Tamas K Lengyel , Keir Fraser , Ian Campbell , Razvan Cojocaru , Jun Nakajima , Stefano Stabellini , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 2/8/2016 7:04 PM, Andrew Cooper wrote: > On 08/02/16 16:57, Corneliu ZUZU wrote: >> X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, >> also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. >> >> Signed-off-by: Corneliu ZUZU > For future reference, constructing your patches with -M (detect renames) > makes reviews of patches like this far easier. > > While you are editing this file, please put a local variable block on > the bottom of the file. See the final section of CODING_STYLE in the root. > > ~Andrew > I'm really sorry, I forgot, I was actually *counting* on that option, wanted to use it as -M40% actually. And I really don't get why git malformed the introductory message. Since the diffs would indeed look *much* better w/ the -M option and I should also add the variable block @ the end of that file (which was originally missing) would it be advised to resend this series? Corneliu.