From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/7] arm: move arch/arm/hvm.c to
	arch/arm/hvm/hvm.c
Date: Mon, 8 Feb 2016 17:14:28 +0000
Message-ID: <56B8CCF4.3090703@citrix.com>
References: <1454950682-9459-1-git-send-email-czuzu@bitdefender.com>
	<1454950682-9459-2-git-send-email-czuzu@bitdefender.com>
	<56B8CA95.2010108@citrix.com> <56B8CC7E.2040309@bitdefender.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56B8CC7E.2040309@bitdefender.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Corneliu ZUZU <czuzu@bitdefender.com>, xen-devel@lists.xen.org
Cc: Kevin Tian <kevin.tian@intel.com>, Tamas K Lengyel <tamas@tklengyel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, Jun Nakajima <jun.nakajima@intel.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 08/02/16 17:12, Corneliu ZUZU wrote:
> On 2/8/2016 7:04 PM, Andrew Cooper wrote:
>> On 08/02/16 16:57, Corneliu ZUZU wrote:
>>> X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry,
>>> also move arch/arm/hvm.c to arch/arm/hvm/hvm.c.
>>>
>>> Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>
>> For future reference, constructing your patches with -M (detect renames)
>> makes reviews of patches like this far easier.
>>
>> While you are editing this file, please put a local variable block on
>> the bottom of the file.  See the final section of CODING_STYLE in the
>> root.
>>
>> ~Andrew
>>
> I'm really sorry, I forgot, I was actually *counting* on that option,
> wanted to use it as -M40%
> actually. And I really don't get why git malformed the introductory
> message.
> Since the diffs would indeed look *much* better w/ the -M option and I
> should also add
> the variable block @ the end of that file (which was originally
> missing) would it be advised to
> resend this series?

I would wait for some other review first.  There are some useful
comments to be given even with the series like this.

~Andrew