From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corneliu ZUZU Subject: Re: [PATCH 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h Date: Mon, 8 Feb 2016 20:55:50 +0200 Message-ID: <56B8E4B6.3020805@bitdefender.com> References: <1454950682-9459-1-git-send-email-czuzu@bitdefender.com> <1454950682-9459-5-git-send-email-czuzu@bitdefender.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7416804419153865126==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel Cc: Kevin Tian , Keir Fraser , Ian Campbell , Razvan Cojocaru , Jun Nakajima , Andrew Cooper , Xen-devel , Stefano Stabellini , Jan Beulich List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============7416804419153865126== Content-Type: multipart/alternative; boundary="------------060501070402060404040504" This is a multi-part message in MIME format. --------------060501070402060404040504 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2/8/2016 8:18 PM, Tamas K Lengyel wrote: > > > On Mon, Feb 8, 2016 at 9:57 AM, Corneliu ZUZU > wrote: > > (last commit before this one explains why this was necessary) > > Signed-off-by: Corneliu ZUZU > > > > I assume this patch will be gone in the next iteration after using -M > so skipping it now. > > Tamas > No, originally I intended to use the -M option, I just forgot. This is needed even w/ the -M option. The reason is git seeing file /a.c as being modified when moving it to /a.c and at the same time adding /a.c in place of the old one, *even if* the similarity between the old /a.c and /a.c would be *100%* and you'd use the -M option. A google-search led me to a 2009-dated page that described this as a lack of git diff's algo that would be improved upon. It seems they aren't there yet. Corneliu. --------------060501070402060404040504 Content-Type: text/html; charset=utf-8 Content-Length: 2329 Content-Transfer-Encoding: quoted-printable

On 2/8/2016 8:18 PM, Tamas K Lengyel wrote:

On Mon, Feb 8, 2016 at 9:57 AM, Corneliu ZUZU <czuzu@bitdefender.com> wrote:

(last commit before this one explains why this was necessary)

Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>

I assume this patch will be gone in the next iteration after using -M so skipping it now.

Tamas

No, originally I intended to use the -M option, I just forgot.
This is needed even w/ the -M option.
The reason is git seeing file <somepath1>/a.c=C2=A0 as being modified
when moving it to <somepath2>/a.c and at the same time adding
<somepath1>/a.c in place of the old one, *even if* the similarity
between the old <somepath1>/a.c and <somepath2>/a.c would be *100%*
and you'd use the -M option. A google-search led me to a 2009-dated page
that described this as a lack of git diff's algo that would be improved upon.
It seems they aren't there yet.

Corneliu.
--------------060501070402060404040504-- --===============7416804419153865126== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7416804419153865126==--