From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suman Anna Subject: Re: [PATCH 0/3] omap: hwmod: add default reset handling support Date: Mon, 8 Feb 2016 15:07:08 -0600 Message-ID: <56B9037C.2050203@ti.com> References: <1454929941-23949-1-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1454929941-23949-1-git-send-email-kishon@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Kishon Vijay Abraham I , Paul Walmsley , Tony Lindgren , bhelgaas@google.com, richardcochran@gmail.com Cc: Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcousson@baylibre.com, nsekhar@ti.com, Dave Gerlach List-Id: linux-omap@vger.kernel.org On 02/08/2016 05:12 AM, Kishon Vijay Abraham I wrote: > Add a new hwmod flag to indicate custom reset handling and use it > for devices that require custom reset handling (like dsp, ipu, iva). > > Tested PCIe on dra7-evm and dra72-evm. > I need help in testing DSP, IPU, IVA, PRU, GFX, M3 in other platforms. > Or a way to test these cores to see if reset is not broken. Suman? I won't be able to test this week, and have requested Dave to check on wkup_m3_rproc driver atleast. I see one potential issue (see my commment on the other thread), but can confirm that only after testing. Have you tested multiple probe/removal sequences? Can you check the return status on the _hardreset_deassert call with your PCIe driver, believe even that one would return an error on multiple probes. regards Suman > > I'll post this series once again after performing these tests. > > Paul Walmsley (3): > ARM: omap2+: omap_hwmod: introduce hwmod flag for custom reset > handling > ARM: OMAP2+: hwmod: use HWMOD_CUSTOM_HARDRESET for custom reset > handling > ARM: OMAP2+: hwmod: Add default reset handling > > arch/arm/mach-omap2/omap_hwmod.c | 16 +++++++++++----- > arch/arm/mach-omap2/omap_hwmod.h | 12 ++++++++++++ > arch/arm/mach-omap2/omap_hwmod_2420_data.c | 2 ++ > arch/arm/mach-omap2/omap_hwmod_2430_data.c | 1 + > .../mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 2 ++ > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 1 + > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 3 +++ > arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 1 + > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 6 ++++++ > arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 2 ++ > 10 files changed, 41 insertions(+), 5 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: s-anna@ti.com (Suman Anna) Date: Mon, 8 Feb 2016 15:07:08 -0600 Subject: [PATCH 0/3] omap: hwmod: add default reset handling support In-Reply-To: <1454929941-23949-1-git-send-email-kishon@ti.com> References: <1454929941-23949-1-git-send-email-kishon@ti.com> Message-ID: <56B9037C.2050203@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/08/2016 05:12 AM, Kishon Vijay Abraham I wrote: > Add a new hwmod flag to indicate custom reset handling and use it > for devices that require custom reset handling (like dsp, ipu, iva). > > Tested PCIe on dra7-evm and dra72-evm. > I need help in testing DSP, IPU, IVA, PRU, GFX, M3 in other platforms. > Or a way to test these cores to see if reset is not broken. Suman? I won't be able to test this week, and have requested Dave to check on wkup_m3_rproc driver atleast. I see one potential issue (see my commment on the other thread), but can confirm that only after testing. Have you tested multiple probe/removal sequences? Can you check the return status on the _hardreset_deassert call with your PCIe driver, believe even that one would return an error on multiple probes. regards Suman > > I'll post this series once again after performing these tests. > > Paul Walmsley (3): > ARM: omap2+: omap_hwmod: introduce hwmod flag for custom reset > handling > ARM: OMAP2+: hwmod: use HWMOD_CUSTOM_HARDRESET for custom reset > handling > ARM: OMAP2+: hwmod: Add default reset handling > > arch/arm/mach-omap2/omap_hwmod.c | 16 +++++++++++----- > arch/arm/mach-omap2/omap_hwmod.h | 12 ++++++++++++ > arch/arm/mach-omap2/omap_hwmod_2420_data.c | 2 ++ > arch/arm/mach-omap2/omap_hwmod_2430_data.c | 1 + > .../mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 2 ++ > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 1 + > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 3 +++ > arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 1 + > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 6 ++++++ > arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 2 ++ > 10 files changed, 41 insertions(+), 5 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756196AbcBHVHn (ORCPT ); Mon, 8 Feb 2016 16:07:43 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:46385 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753799AbcBHVHl (ORCPT ); Mon, 8 Feb 2016 16:07:41 -0500 Subject: Re: [PATCH 0/3] omap: hwmod: add default reset handling support To: Kishon Vijay Abraham I , Paul Walmsley , Tony Lindgren , , References: <1454929941-23949-1-git-send-email-kishon@ti.com> CC: Russell King , , , , , , Dave Gerlach From: Suman Anna Message-ID: <56B9037C.2050203@ti.com> Date: Mon, 8 Feb 2016 15:07:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454929941-23949-1-git-send-email-kishon@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2016 05:12 AM, Kishon Vijay Abraham I wrote: > Add a new hwmod flag to indicate custom reset handling and use it > for devices that require custom reset handling (like dsp, ipu, iva). > > Tested PCIe on dra7-evm and dra72-evm. > I need help in testing DSP, IPU, IVA, PRU, GFX, M3 in other platforms. > Or a way to test these cores to see if reset is not broken. Suman? I won't be able to test this week, and have requested Dave to check on wkup_m3_rproc driver atleast. I see one potential issue (see my commment on the other thread), but can confirm that only after testing. Have you tested multiple probe/removal sequences? Can you check the return status on the _hardreset_deassert call with your PCIe driver, believe even that one would return an error on multiple probes. regards Suman > > I'll post this series once again after performing these tests. > > Paul Walmsley (3): > ARM: omap2+: omap_hwmod: introduce hwmod flag for custom reset > handling > ARM: OMAP2+: hwmod: use HWMOD_CUSTOM_HARDRESET for custom reset > handling > ARM: OMAP2+: hwmod: Add default reset handling > > arch/arm/mach-omap2/omap_hwmod.c | 16 +++++++++++----- > arch/arm/mach-omap2/omap_hwmod.h | 12 ++++++++++++ > arch/arm/mach-omap2/omap_hwmod_2420_data.c | 2 ++ > arch/arm/mach-omap2/omap_hwmod_2430_data.c | 1 + > .../mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 2 ++ > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 1 + > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 3 +++ > arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 1 + > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 6 ++++++ > arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 2 ++ > 10 files changed, 41 insertions(+), 5 deletions(-) >