Re: [PATCH] drm/i915: Skip DDI PLL selection for DSI

From: "Thulasimani, Sivakumar" <sivakumar.thulasimani@intel.com>
To: Mika Kahola <mika.kahola@intel.com>, intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: Re: [PATCH] drm/i915: Skip DDI PLL selection for DSI
Date: Tue, 9 Feb 2016 08:22:27 +0530	[thread overview]
Message-ID: <56B9546B.6070107@intel.com> (raw)
In-Reply-To: <1454671768-27062-1-git-send-email-mika.kahola@intel.com>


On 2/5/2016 4:59 PM, Mika Kahola wrote:
> Skip DDI PLL selection if display type is DSI/MIPI.
>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_display.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index d7de2a5..5da98b2 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9902,8 +9902,13 @@ static void broadwell_modeset_commit_cdclk(struct drm_atomic_state *old_state)
>   static int haswell_crtc_compute_clock(struct intel_crtc *crtc,
>   				      struct intel_crtc_state *crtc_state)
>   {
> -	if (!intel_ddi_pll_select(crtc, crtc_state))
> -		return -EINVAL;
> +	struct intel_encoder *intel_encoder =
> +		intel_ddi_get_crtc_new_encoder(crtc_state);
> +
> +	if (intel_encoder->type != INTEL_OUTPUT_DSI) {
> +		if (!intel_ddi_pll_select(crtc, crtc_state))
> +			return -EINVAL;
> +	}
>   
can this be moved inside bxt_ddi_pll_select ? we can avoid this check for
other platforms that also execute this function.

regards,
Sivakumar
>   	crtc->lowfreq_avail = false;
>   

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx