From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH 1/2] xenoprof: fix up ability to disable it Date: Mon, 8 Feb 2016 21:01:28 -0600 Message-ID: <56B95688.1050607@cardoe.com> References: <1454947487-8588-1-git-send-email-cardoe@cardoe.com> <56B8C122.1060207@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2424896028343257241==" Return-path: In-Reply-To: <56B8C122.1060207@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky , xen-devel@lists.xen.org Cc: Kevin Tian , Keir Fraser , Jan Beulich , Jun Nakajima , Andrew Cooper , Aravind Gopalakrishnan , Suravee Suthikulpanit List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2424896028343257241== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qFnJCPD0UWbo8Aon06Lg0RCBD4kv2Jcbg" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qFnJCPD0UWbo8Aon06Lg0RCBD4kv2Jcbg Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2/8/16 10:24 AM, Boris Ostrovsky wrote: >=20 >=20 > On 02/08/2016 11:04 AM, Doug Goldstein wrote: >> Allow Xenoprof to be fully disabled when toggling the option off. >> >> CC: Keir Fraser >> CC: Jan Beulich >> CC: Andrew Cooper >> CC: Boris Ostrovsky >> CC: Suravee Suthikulpanit >> CC: Aravind Gopalakrishnan >> CC: Jun Nakajima >> CC: Kevin Tian >> Signed-off-by: Doug Goldstein >=20 >=20 >> @@ -2666,10 +2669,11 @@ static int vmx_msr_write_intercept(unsigned >> int msr, uint64_t msr_content) >> goto gp_fault; >> break; >> default: >> - if ( passive_domain_do_wrmsr(msr, msr_content) ) >> + if ( IS_ENABLED(CONFIG_XENOPROF) && >> + passive_domain_do_wrmsr(msr, msr_content) ) >> return X86EMUL_OKAY; >> - if ( wrmsr_viridian_regs(msr, msr_content) ) >> + if ( wrmsr_viridian_regs(msr, msr_content) ) >> break; >=20 > Looks like a stray change. >=20 > Other than that, >=20 > Reviewed-by: Boris Ostrovsky >=20 > While at it --- I think we should put VPMU code under CONFIG option too= , > especially given its support status. I can do that (unless Doug wants t= o). >=20 > -boris Boris, Thanks for the review. I didn't add your Reviewed-by because I've reworked this patch to take into account Andrew Cooper's suggestion to provide dummy function calls instead of wrapping everything with IS_ENABLED(). --=20 Doug Goldstein --qFnJCPD0UWbo8Aon06Lg0RCBD4kv2Jcbg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWuVaNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUoBYP/1mNbOaRuG7eUI2NFUXsGxQf XAMel5mids33QGpbedzvplA2iR0OG0oF4hBQtVGTIy5R9G8boggSePH1mA6lD3Fh A8ffFA90diaGAPg3O6ElLOw7uUd1lrHe8PtmqwDFeIrH1I5EOA9Vot+MrrziGR6F rh95J7zrOkjfecQNdrm4VaTgjw4bAToHMMqt0B0ZVEKFYP+R0J1md0EFk7CKX2EN jk6sHYj3fmYnIr+ZduQWTq++DffLnglT0ukx2WTXGboODS56wHZYA56cVvZs1AGR uAkVg3vuCxgCjiHiqWVq3N97/IVPnVMag05DeVqcNtDGGb7HHsymlL+I9izqmFAJ 44joqmczASC4iTxv0js2zEjQiiKRMi4rPo6bCmSCf91LO4e3RlhOpsL4wDeOvNI5 CjMF+uJkCc1BqE+nIR70e/X5lCH+/oNdvD+2rbh2V/ngSltNYuGy7lbnRk9B4rPC IjwgTex+8iyrMpLjypA3+5qhHKBA54cIpyoPSROvwubFHMivc5luB/+TDsA0Zz3n rJ5Dorr35E5S6+aS7znfThhbIvmm8W44EL8ukDFK560tT2EshCX9GZqSKYESZpAo jarUP9Q7shwPIgbYtpRc1f9nYxxFRZwuMwo2B2OxzBt9b5W+rfWeh/bhW0ajjXV7 Bv1DsXld8/nX/CTdJdrO =b+Tw -----END PGP SIGNATURE----- --qFnJCPD0UWbo8Aon06Lg0RCBD4kv2Jcbg-- --===============2424896028343257241== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2424896028343257241==--