From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH v2 4/4] virtio: use pci ioport api
Date: Tue, 9 Feb 2016 12:52:30 +0900
Message-ID: <56B9627E.6080904@igel.co.jp>
References: <1454694945-18040-1-git-send-email-david.marchand@6wind.com>
 <1454831317-4542-1-git-send-email-david.marchand@6wind.com>
 <1454831317-4542-5-git-send-email-david.marchand@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
To: David Marchand <david.marchand@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com
 [209.85.192.181]) by dpdk.org (Postfix) with ESMTP id 1EDC391BF
 for <dev@dpdk.org>; Tue,  9 Feb 2016 04:52:34 +0100 (CET)
Received: by mail-pf0-f181.google.com with SMTP id e127so25071729pfe.3
 for <dev@dpdk.org>; Mon, 08 Feb 2016 19:52:34 -0800 (PST)
In-Reply-To: <1454831317-4542-5-git-send-email-david.marchand@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2016/02/07 16:48, David Marchand wrote:
> Move all os / arch specifics to eal.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
>  drivers/net/virtio/virtio_pci.c | 339 +++++++---------------------------------
>  drivers/net/virtio/virtio_pci.h |  38 +----
>  2 files changed, 55 insertions(+), 322 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c
> index b1610dd..e04c0db 100644
> --- a/drivers/net/virtio/virtio_pci.c
> +++ b/drivers/net/virtio/virtio_pci.c
> @@ -49,74 +49,35 @@
>
> @@ -311,132 +191,20 @@ legacy_virtio_has_msix(const struct rte_pci_addr *loc)
>  
>  /* Extract I/O port numbers from sysfs */
>  static int
> -virtio_resource_init_by_uio(struct rte_pci_device *pci_dev)
> +legacy_virtio_resource_init(struct rte_pci_device *pci_dev,
> +			    struct virtio_hw *hw)

One more legacy_virtio_resource_init() is defined like below.

#ifdef RTE_EXEC_ENV_LINUXAPP
<snip>
#else
<snip>
static int
legacy_virtio_resource_init(struct rte_pci_device *pci_dev __rte_unused)
{
        /* no setup required */
        return 0;
}
#endif

Should we change this also?

Thanks,
Tetsuya