From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH 1/2] xenoprof: fix up ability to disable it Date: Mon, 8 Feb 2016 22:05:02 -0600 Message-ID: <56B9656E.9050407@cardoe.com> References: <1454947487-8588-1-git-send-email-cardoe@cardoe.com> <56B8C122.1060207@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8706049587290297891==" Return-path: In-Reply-To: <56B8C122.1060207@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky , xen-devel@lists.xen.org Cc: Kevin Tian , Keir Fraser , Jan Beulich , Jun Nakajima , Andrew Cooper , Aravind Gopalakrishnan , Suravee Suthikulpanit List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============8706049587290297891== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Bi5namKqMN6H19N9g2Vb9CU4se2WX55v7" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Bi5namKqMN6H19N9g2Vb9CU4se2WX55v7 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2/8/16 10:24 AM, Boris Ostrovsky wrote: >=20 >=20 > On 02/08/2016 11:04 AM, Doug Goldstein wrote: >> Allow Xenoprof to be fully disabled when toggling the option off. >> >> CC: Keir Fraser >> CC: Jan Beulich >> CC: Andrew Cooper >> CC: Boris Ostrovsky >> CC: Suravee Suthikulpanit >> CC: Aravind Gopalakrishnan >> CC: Jun Nakajima >> CC: Kevin Tian >> Signed-off-by: Doug Goldstein >=20 >=20 >> @@ -2666,10 +2669,11 @@ static int vmx_msr_write_intercept(unsigned >> int msr, uint64_t msr_content) >> goto gp_fault; >> break; >> default: >> - if ( passive_domain_do_wrmsr(msr, msr_content) ) >> + if ( IS_ENABLED(CONFIG_XENOPROF) && >> + passive_domain_do_wrmsr(msr, msr_content) ) >> return X86EMUL_OKAY; >> - if ( wrmsr_viridian_regs(msr, msr_content) ) >> + if ( wrmsr_viridian_regs(msr, msr_content) ) >> break; >=20 > Looks like a stray change. >=20 > Other than that, >=20 > Reviewed-by: Boris Ostrovsky >=20 > While at it --- I think we should put VPMU code under CONFIG option too= , > especially given its support status. I can do that (unless Doug wants t= o). >=20 > -boris Boris, I forgot to answer the VPMU part. If you have the bandwidth to do that I'll happily test it. Otherwise I'm not sure when I'll have a chance to wrap it with Kconfig. --=20 Doug Goldstein --Bi5namKqMN6H19N9g2Vb9CU4se2WX55v7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWuWVyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUDMsP/jdEdV2jHvjRPf5UpmbPtl7e QoaKf3XEGa2dqQ2FaQBNtFRJ6u9v72Wi1dKBuTka6ZVB8VPZTQ2pveDmLI9eGEW3 nxUGjo4caiPFuh3lPNtfGAcVRJwe9+vkGZBJMulqDTvIfyQdJvqCme05OxzWjSLX 9YSC9penv7ATxY28kms1/URuhYU1CsUwgc4Dkno1b3NL4hL800CXJJsQmqMd1wUZ dHhib4cpZndhu5FOMwz1YO44Tc1+KMOjI2LEiTKA6ohiYoP8C9nLBbv1twqNkwZZ /DYGlEMjyr2S2Bj2afUTef9/eemxuKKeXZNMnu0v2cVJj8IY2lYq1ZPzcsJNcp6L imxyeA3RAO1qB2x8s64E4HAFqx9lDzClKTw9NI6viw2Ptv393xD5s7xoc6EWZTaF A2pscBT93fbzlldSVpsqpFTxNwJ+5BGJEV23w84XbYie3iczAp25OiCRV2z+pqmp QzGbQi1+VJ3k81KR2vuytKaRpksyEPQ8xq2BWHzUXp74UQROEC6qfQ9s/mIg1x2+ DFuoSd+med6vJtYUzkS9VxvMPccgFa1k3mE7+Peyv8Meh8ODNUr7dJaEY0pw+O2l tl45NJ32kkSSABRjYGbq7tCiLVVdNFmHcu4RaqTwMrMfMFBpQ+U5piSIi5vehSOD xPdPPqxq15ItLDNobdjk =SGZE -----END PGP SIGNATURE----- --Bi5namKqMN6H19N9g2Vb9CU4se2WX55v7-- --===============8706049587290297891== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8706049587290297891==--