From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Subject: Re: [PATCH] x86/HVM: rewrite the start info structure definition in binary form Date: Tue, 9 Feb 2016 11:38:43 +0100 Message-ID: <56B9C1B3.2010402@citrix.com> References: <1454675320-29429-1-git-send-email-roger.pau@citrix.com> <56B4AE1C02000078000CF06E@prv-mh.provo.novell.com> <56B4C39E.50206@citrix.com> <56B9ADE502000078000CFDFC@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aT5h6-0005Sf-CZ for xen-devel@lists.xenproject.org; Tue, 09 Feb 2016 10:38:52 +0000 In-Reply-To: <56B9ADE502000078000CFDFC@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Wei Liu , Ian Campbell , Andrew Cooper , Ian Jackson , Samuel Thibault , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org El 9/2/16 a les 9:14, Jan Beulich ha escrit: >>>> On 05.02.16 at 16:45, wrote: >> El 5/2/16 a les 14:13, Jan Beulich ha escrit: >>> But >>> even then - wouldn't what I've read on the other thread mean >>> at least the filename should be put there (as kind of the first >>> command line element)? >> >> Really? I didn't get that impression at all, what's the filename useful >> for anyway? > > This largely depends on whether you mean to mimic multiboot1 or > multiboot2. Remember the placeholder people have to add to > certain grub2 invocation lines? I think that's a result of their > attempt to had through a file name. But indeed - I've never > understood what it's good for until this request came about: How > else would the consumer know which module is which if there's no > signature or alike inside the file? Iirc someone suggested (in the > context of the discussion here) that Linux might look for "initrd" > in the filename to identify that one. Seems fragile to me, but may > be the only alternative if not demanding multiple modules to be > ordered in a certain way. OK, right now xl/libxl only allows passing one module that's considered the initram/ramdisk from Linux PoV. Other OSes that use the pv loader don't pass any module at all AFAIK. The problem is that there's no way to specify a command line parameter for modules, and I think in order to make use of this we should add such option, instead of hard coding "initrd" as the command line of the first module. However, I don't think any of this should prevent this patch from being accepted. If someone has interest in implementing a way to pass module command line arguments please feel free to do it, this patch just sets the right ABI for doing so, although it's unused at the moment. Roger.